From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Add 'bytevector-slice'. Date: Sat, 14 Jan 2023 16:19:49 +0100 Message-ID: <87358d9m96.fsf@gnu.org> References: <20230111150015.10219-1-ludo@gnu.org> <57a2d974-0278-409c-678a-6daf7672ba81@telenet.be> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18439"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Cc: guile-devel@gnu.org, Andy Wingo To: Maxime Devos Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Sat Jan 14 16:20:14 2023 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pGiKL-0004cG-5U for guile-devel@m.gmane-mx.org; Sat, 14 Jan 2023 16:20:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pGiK1-00075X-Ob; Sat, 14 Jan 2023 10:19:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGiK0-00075N-W8 for guile-devel@gnu.org; Sat, 14 Jan 2023 10:19:53 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGiK0-0005Hc-J6; Sat, 14 Jan 2023 10:19:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=aiCXpX83vshGDPcrypU9DlBoTwe12zL4qcQonhBCtMo=; b=mfZNGNS29afPoW3D5cfH 3D4Rhv0Fog2S0+CyezSU61KMG4Xa9YGIRAfpVDIiHCn/yDXRUU/mohLBzubwLscGRdNiD2FlMH+7I zzjV3jgQwDhjDUBJ4pdSnQHZfHQi5hH5hyn2jADDcrDr7CyHZAxLOd7RRXx4wpHwRExx3TV2o1qUN D3eLKVhVHl58KaP7JbT0KcZKoo44lYOYYoZixEKy8BTNiqZ2AD5kzZiknOeH3QlNajoTpz6Y0ZamV whEHExdHlWp7VdSHjyKMFWq9oxW0jsDKgkytsT62OYw6W6z43Ag+HrG0bHDjPz23j2yAbjFqGmCXR dDpzrCECj2s3Og==; Original-Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGiK0-0003Ys-6O; Sat, 14 Jan 2023 10:19:52 -0500 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quintidi 25 =?utf-8?Q?Niv=C3=B4se?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Chat X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu In-Reply-To: <57a2d974-0278-409c-678a-6daf7672ba81@telenet.be> (Maxime Devos's message of "Thu, 12 Jan 2023 01:10:57 +0100") X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.devel:21584 Archived-At: Hello! I pushed the patch as commit e441c34f1666921f6b15597c1aa3a50596a129d7 with the following changes taking into account your comments: =E2=80=A2 adjusted copyright years; =E2=80=A2 removed comment about =E2=80=98SCM_F_BYTEVECTOR_CONTIGUOUS=E2= =80=99 since it=E2=80=99s quite clear from the discussion in this thread that this flag is vestigial; =E2=80=A2 added an overflow check for =E2=80=98c_offset + c_size=E2=80=99= and a corresponding test (really glad you reported this one!); =E2=80=A2 added another missing test that you mentioned. I did not update the license header as you suggested, but I think we should run a script on all the repo to homogenize those but it=E2=80=99s a = bit messy right now. Thanks, Ludo=E2=80=99.