unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Tomas Volf <~@wolfsden.cz>
To: Mikael Djurfeldt <mikael@djurfeldt.com>
Cc: janneke@gnu.org, guile-devel <guile-devel@gnu.org>,
	"Ludovic Courtès" <ludo@gnu.org>, guile-user <guile-user@gnu.org>,
	"Andy Wingo" <wingo@pobox.com>
Subject: Re: Keywords in GOOPS methods
Date: Fri, 22 Nov 2024 12:46:45 +0100	[thread overview]
Message-ID: <8734jj1oey.fsf@wolfsden.cz> (raw)
In-Reply-To: <CAA2XvwKnZmeNj2tjX_3ukna9fGcUornpA9eEEOnZFexsNMiEMA@mail.gmail.com> (Mikael Djurfeldt's message of "Thu, 21 Nov 2024 23:51:45 +0100")

[-- Attachment #1: Type: text/plain, Size: 1162 bytes --]

Hello,

opinion from the peanut gallery below.

Mikael Djurfeldt <mikael@djurfeldt.com> writes:

> Any opinions on what is best: Having a define-method* or having the
> functionality in define-method itself?

I do find the symmetry between define-method/define-method* and
define/define* pleasing.

For define and define*, one could argue that procedures produced by the
latter are slower to call (I did measure).  Is that an issue here as
well?  (I guess one could argue that people writing object oriented code
with run-time dispatch are usually not driven by performance as the main
metric.)

You did mention backwards compatibility, but how serious you expect the
issue would be?  I personally did not use GOOPS yet, but I have a hard
time imagining a real-world code that would be broken by this change.
Do you expect there would actually be any?

I personally would probably lean towards two separate procedures (mainly
due to the assumption of there being a performance impact).

Have a nice day,
Tomas Volf
 
-- 
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]

  reply	other threads:[~2024-11-22 11:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-19 16:41 Keywords in GOOPS methods Mikael Djurfeldt
2024-11-21 20:33 ` Mikael Djurfeldt
2024-11-21 20:33   ` Mikael Djurfeldt
2024-11-21 22:00   ` janneke
2024-11-21 22:51     ` Mikael Djurfeldt
2024-11-22 11:46       ` Tomas Volf [this message]
2024-11-22 12:28         ` Mikael Djurfeldt
2024-11-22 12:20       ` janneke
2024-11-22 12:29         ` Mikael Djurfeldt
2024-11-22 23:04           ` Mikael Djurfeldt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734jj1oey.fsf@wolfsden.cz \
    --to=~@wolfsden.cz \
    --cc=guile-devel@gnu.org \
    --cc=guile-user@gnu.org \
    --cc=janneke@gnu.org \
    --cc=ludo@gnu.org \
    --cc=mikael@djurfeldt.com \
    --cc=wingo@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).