From: Kevin Ryde <user42@zip.com.au>
Cc: guile-devel@gnu.org
Subject: Re: mapping.scm and hashx-remove!
Date: Thu, 09 Oct 2003 07:16:43 +1000 [thread overview]
Message-ID: <871xtnbfb8.fsf@zip.com.au> (raw)
In-Reply-To: <87vfr17xtq.fsf@zagadka.ping.de> (Marius Vollmer's message of "Tue, 07 Oct 2003 19:38:09 +0200")
Marius Vollmer <mvo@zagadka.de> writes:
>
> Right. Can you write a test case for this and fix it? That would be
> great!
I added some words to the todo file instead. The functions taken by
hashx_remove seem sub-optimal.
- hashx-remove!, corresponding to other hash*-remove! functions.
scm_hashx_remove_x exists, but has never been documented, and
might be non-functional (looks like it's missing "&closure" in the
scm_hash_fn_remove_x call).
Might want to think about the procedures taken. Separate assoc
and delete! suit existing such functions, but it's wasteful to
traverse a bucket list once to see if an element exists, then
again to delete it. Think about maybe a function returning both a
modified list and a flag indicating whether a delete was done. Or
maybe just returning the list tail of the target element.
- mapping.scm hash-table-mapping-hooks uses hashx-create-handle,
which doesn't exist. Probably a typo for hashx-create-handle!,
just wants to get a little test program to exercise it.
- mapping.scm hash-table-mapping-hooks uses hashx-get-handle in its
constructed delete-proc, which is probably meant to be
hashx-remove!, if/when such a function exists.
_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel
prev parent reply other threads:[~2003-10-08 21:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-20 23:23 mapping.scm and hashx-remove! Kevin Ryde
2003-10-07 17:38 ` Marius Vollmer
2003-10-08 21:16 ` Kevin Ryde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871xtnbfb8.fsf@zip.com.au \
--to=user42@zip.com.au \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).