srfi-13 string-trim isspace on char

srfi-13 string-trim isspace on char

[Kevin Ryde]

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

        * srfi-13.c (scm_string_trim, scm_string_trim_right,
        scm_string_trim_both): Cast to unsigned char for isspace.

glibc works with negative char values, but c99 doesn't allow them.

On solaris 7, isspace is an array lookup and a char as an index
provokes a warning from gcc (3.3 at least).

This would probably be for the 1.6 branch too.


[-- Attachment #2: srfi-13.c.isspace.diff --]
[-- Type: text/plain, Size: 1109 bytes --]

--- srfi-13.c.~1.19.~	2003-04-07 08:05:29.000000000 +1000
+++ srfi-13.c	2004-04-06 11:21:46.000000000 +1000
@@ -1,6 +1,6 @@
 /* srfi-13.c --- SRFI-13 procedures for Guile
  *
- * Copyright (C) 2001 Free Software Foundation, Inc.
+ * Copyright (C) 2001, 2004 Free Software Foundation, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
@@ -593,7 +593,7 @@
     {
       while (cstart < cend)
 	{
-	  if (!isspace(cstr[cstart]))
+	  if (!isspace((int) (unsigned char) cstr[cstart]))
 	    break;
 	  cstart++;
 	}
@@ -668,7 +668,7 @@
     {
       while (cstart < cend)
 	{
-	  if (!isspace(cstr[cend - 1]))
+	  if (!isspace((int) (unsigned char) cstr[cend - 1]))
 	    break;
 	  cend--;
 	}
@@ -743,13 +743,13 @@
     {
       while (cstart < cend)
 	{
-	  if (!isspace(cstr[cstart]))
+	  if (!isspace((int) (unsigned char) cstr[cstart]))
 	    break;
 	  cstart++;
 	}
       while (cstart < cend)
 	{
-	  if (!isspace(cstr[cend - 1]))
+	  if (!isspace((int) (unsigned char) cstr[cend - 1]))
 	    break;
 	  cend--;
 	}

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel

Re: srfi-13 string-trim isspace on char

[Marius Vollmer]

Kevin Ryde <user42@zip.com.au> writes:

> This would probably be for the 1.6 branch too.

Yes, I have applied the patch.  Thanks!

-- 
GPG: D5D4E405 - 2F9B BCCC 8527 692A 04E3  331E FAF8 226A D5D4 E405


_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel