From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kevin Ryde Newsgroups: gmane.lisp.guile.devel Subject: Re: mingw patch Date: Sat, 30 Apr 2005 09:54:59 +1000 Message-ID: <871x8tkujw.fsf@zip.com.au> References: <87zmvj98oe.fsf@peder.flower> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1114969198 27385 80.91.229.2 (1 May 2005 17:39:58 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 1 May 2005 17:39:58 +0000 (UTC) Cc: Han-Wen Nienhuys , guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sun May 01 19:39:55 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DSIPS-00020V-7f for guile-devel@m.gmane.org; Sun, 01 May 2005 19:39:15 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DSIWB-0005yw-Mz for guile-devel@m.gmane.org; Sun, 01 May 2005 13:46:11 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DSIAg-0003xh-BC for guile-devel@gnu.org; Sun, 01 May 2005 13:23:58 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DSIAc-0003vr-PC for guile-devel@gnu.org; Sun, 01 May 2005 13:23:55 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DSIAX-0003dN-AL for guile-devel@gnu.org; Sun, 01 May 2005 13:23:49 -0400 Original-Received: from [199.232.41.67] (helo=mx20.gnu.org) by monty-python.gnu.org with esmtp (TLS-1.0:RSA_ARCFOUR_SHA:16) (Exim 4.34) id 1DSHnn-0007Lm-Pu; Sun, 01 May 2005 13:00:19 -0400 Original-Received: from [61.8.0.84] (helo=mailout1.pacific.net.au) by mx20.gnu.org with esmtp (Exim 4.34) id 1DRfMb-0003Qs-UE; Fri, 29 Apr 2005 19:57:42 -0400 Original-Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87]) by mailout1.pacific.net.au (8.12.3/8.12.3/Debian-7.1) with ESMTP id j3TNtZJu012880; Sat, 30 Apr 2005 09:55:35 +1000 Original-Received: from localhost (ppp2D4C.dyn.pacific.net.au [61.8.45.76]) by mailproxy2.pacific.net.au (8.12.3/8.12.3/Debian-7.1) with ESMTP id j3TNtB0H020339; Sat, 30 Apr 2005 09:55:23 +1000 Original-Received: from gg by localhost with local (Exim 3.36 #1 (Debian)) id 1DRfJz-0002Hw-00; Sat, 30 Apr 2005 09:54:59 +1000 Original-To: Jan Nieuwenhuizen Mail-Copies-To: never In-Reply-To: <87zmvj98oe.fsf@peder.flower> (Jan Nieuwenhuizen's message of "Thu, 28 Apr 2005 00:06:09 +0200") User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3 (gnu/linux) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:4930 X-Report-Spam: http://spam.gmane.org/gmane.lisp.guile.devel:4930 Jan Nieuwenhuizen writes: > > #ifdef __MINGW32__ > +#define socklen_t int That'd be better as a HAVE_SOCKLEN_T. > +#ifndef __MINGW32__ > struct ip_mreq opt_mreq; And this would definitely be better as a HAVE_STRUCT_IP_MREQ or whatever. Testing for features rather than system names means you don't have to keep adapting to each new system, and if mingw or whatever gains some features in the future then they're automatically used. _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel