From: Kevin Ryde <user42@zip.com.au>
Cc: Han-Wen Nienhuys <hanwen@lilypond.org>, guile-devel@gnu.org
Subject: Re: mingw patch
Date: Sat, 30 Apr 2005 09:54:59 +1000 [thread overview]
Message-ID: <871x8tkujw.fsf@zip.com.au> (raw)
In-Reply-To: <87zmvj98oe.fsf@peder.flower> (Jan Nieuwenhuizen's message of "Thu, 28 Apr 2005 00:06:09 +0200")
Jan Nieuwenhuizen <janneke@gnu.org> writes:
>
> #ifdef __MINGW32__
> +#define socklen_t int
That'd be better as a HAVE_SOCKLEN_T.
> +#ifndef __MINGW32__
> struct ip_mreq opt_mreq;
And this would definitely be better as a HAVE_STRUCT_IP_MREQ or
whatever.
Testing for features rather than system names means you don't have to
keep adapting to each new system, and if mingw or whatever gains some
features in the future then they're automatically used.
_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel
next prev parent reply other threads:[~2005-04-29 23:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-27 22:06 mingw patch Jan Nieuwenhuizen
2005-04-29 23:54 ` Kevin Ryde [this message]
2005-05-02 18:51 ` Jan Nieuwenhuizen
2005-05-18 8:00 ` heromyth
2005-06-05 18:29 ` Marius Vollmer
2005-06-10 12:59 ` Jan Nieuwenhuizen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871x8tkujw.fsf@zip.com.au \
--to=user42@zip.com.au \
--cc=guile-devel@gnu.org \
--cc=hanwen@lilypond.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).