From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [Guile-commits] GNU Guile branch, master, updated. 442f3f20ddd33b43743ea181d95024c10622df52 Date: Tue, 26 May 2009 19:10:50 +0200 Message-ID: <871vqbkcx1.fsf@gnu.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1243357874 32017 80.91.229.12 (26 May 2009 17:11:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 May 2009 17:11:14 +0000 (UTC) Cc: guile-devel@gnu.org To: Andy Wingo Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Tue May 26 19:11:10 2009 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M90BB-0005Dy-Hq for guile-devel@m.gmane.org; Tue, 26 May 2009 19:11:09 +0200 Original-Received: from localhost ([127.0.0.1]:35069 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M90BA-00036X-Nx for guile-devel@m.gmane.org; Tue, 26 May 2009 13:11:08 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M90B4-00036S-C3 for guile-devel@gnu.org; Tue, 26 May 2009 13:11:02 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M90Ay-00036F-A7 for guile-devel@gnu.org; Tue, 26 May 2009 13:11:01 -0400 Original-Received: from [199.232.76.173] (port=32988 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M90Ay-00036C-6s for guile-devel@gnu.org; Tue, 26 May 2009 13:10:56 -0400 Original-Received: from mail4-relais-sop.national.inria.fr ([192.134.164.105]:16261) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1M90Ax-0003ZE-NF for guile-devel@gnu.org; Tue, 26 May 2009 13:10:56 -0400 X-IronPort-AV: E=Sophos;i="4.41,253,1241388000"; d="scan'208";a="40595137" Original-Received: from vpn116.saclay.inria.fr (HELO nixey) ([195.83.213.116]) by mail4-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES128-SHA; 26 May 2009 19:10:53 +0200 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 7 Prairial an 217 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 821D 815D 902A 7EAB 5CEE D120 7FBA 3D4F EB1F 5364 X-OS: i686-pc-linux-gnu In-Reply-To: (Andy Wingo's message of "Tue, 26 May 2009 16:00:40 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.90 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:8522 Archived-At: Hello! Thanks for working on this! "Andy Wingo" writes: > +#if BUILDING_LIBGUILE && HAVE_VISIBILITY > +# define SCM_API extern __attribute__((__visibility__("default"))) > +#elif BUILDING_LIBGUILE && defined _MSC_VER This should be: #if defined BUILDING_LIBGUILE && BUILDING_LIBGUILE && HAVE_VISIBILITY ... Also, I'd have preferred `_GUILE_WITHIN_GUILE', which is clearly in Guile's name space, and is similar to GMP's `__GMP_WITHIN_GMP' ("rule of least surprise"). What do you think? Thanks, Ludo'.