Re: [Guile-commits] GNU Guile branch, master, updated. release_1-9-6-164-gf826a88

Re: [Guile-commits] GNU Guile branch, master, updated. release_1-9-6-164-gf826a88

[Ludovic Courtès]

Hello,

"Andy Wingo" <wingo@pobox.com> writes:

> commit f826a8864a4ec7bfffac0f67d45f8ce0085e9d23
> Author: Andy Wingo <wingo@pobox.com>
> Date:   Fri Jan 15 22:33:49 2010 +0100
>
>     fix (class-of #u32())
>     
>     * libguile/goops.c (scm_class_of, create_standard_classes): Return
>       <bytevector> or <uvec> for bytevectors, as appropriate.
>
> commit 5afa815c9cd4550bf93181bc0ed0134aa83dfc5d
> Author: Andy Wingo <wingo@pobox.com>
> Date:   Fri Jan 15 22:24:31 2010 +0100
>
>     add reader option for parsing [] as ().
>     
>     * libguile/private-options.h:
>     * libguile/read.c (scm_read_opts, SCM_SQUARE_BRACKETS_P): Add an option
>       for treating [ and ] as parentheses, on by default. Note that this
>       makes them delimiters also, so [ and ] cannot appear in a symbol name,
>       with this read option on.
>       (scm_read_sexp): If we start with [, we end with ].
>       (scm_read_expression): Add case for [.

I know you know what I’m going to say ;-), but please add unit tests for
this (and doc for the latter).  It’s easily done, we’ve been doing a
good job at writing such tests so far, and I think it’s worth
continuing.

Thanks,
Ludo’.