From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Rottmann Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] guile-snarf: allow multiple init actions on one line Date: Thu, 24 Feb 2011 21:42:57 +0100 Message-ID: <871v2xgo4u.fsf@rotty.yi.org> References: <87k4grq3tn.fsf@olor.terpri.org> <871v2zpsy5.fsf@olor.terpri.org> <87sjvdw7oa.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1298580227 23975 80.91.229.12 (24 Feb 2011 20:43:47 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 24 Feb 2011 20:43:47 +0000 (UTC) Cc: guile-devel@gnu.org To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Thu Feb 24 21:43:43 2011 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Psi2A-0002ic-GB for guile-devel@m.gmane.org; Thu, 24 Feb 2011 21:43:34 +0100 Original-Received: from localhost ([127.0.0.1]:57919 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Psi29-0007lX-TE for guile-devel@m.gmane.org; Thu, 24 Feb 2011 15:43:34 -0500 Original-Received: from [140.186.70.92] (port=34313 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Psi1l-0007jM-Aq for guile-devel@gnu.org; Thu, 24 Feb 2011 15:43:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Psi1j-0005LC-RR for guile-devel@gnu.org; Thu, 24 Feb 2011 15:43:08 -0500 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:47024) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1Psi1j-0005KB-Ei for guile-devel@gnu.org; Thu, 24 Feb 2011 15:43:07 -0500 Original-Received: (qmail invoked by alias); 24 Feb 2011 20:43:02 -0000 Original-Received: from 83-215-154-5.hage.dyn.salzburg-online.at (EHLO nathot.lan) [83.215.154.5] by mail.gmx.net (mp043) with SMTP; 24 Feb 2011 21:43:02 +0100 X-Authenticated: #3102804 X-Provags-ID: V01U2FsdGVkX18/ii46LRE/+txE273XSAKH2mmTzd7ItwAGlvfG44 82pBnRASo8mBVD Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by nathot.lan (Postfix) with ESMTP id 65A2B3A696; Thu, 24 Feb 2011 21:43:01 +0100 (CET) Original-Received: from nathot.lan ([127.0.0.1]) by localhost (nathot.lan [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EL4deZz38EWZ; Thu, 24 Feb 2011 21:42:57 +0100 (CET) Original-Received: from delenn.lan (delenn.lan [192.168.3.11]) by nathot.lan (Postfix) with ESMTP id A9E853A691; Thu, 24 Feb 2011 21:42:57 +0100 (CET) Original-Received: by delenn.lan (Postfix, from userid 1000) id 83A5A2C00C2; Thu, 24 Feb 2011 21:42:57 +0100 (CET) In-Reply-To: <87sjvdw7oa.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Thu, 24 Feb 2011 20:31:49 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 213.165.64.23 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:11706 Archived-At: ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Hi Brian, > > Thanks for the patches! > > I haven=E2=80=99t look at the other patch yet, but about this one: > > BT Templeton writes: > >> +#!/bin/sh > > Can you add a copyright/license header here? > >> +snarf_test () >> +{ >> + local x >> + x=3D$(snarf "$1") >> + if [ x"$x" !=3D x"$2" ]; then > > =E2=80=98local=E2=80=99 and =E2=80=98$(...)=E2=80=99 are Bash extensions. > That's not true for '$(...)', see SUSv3, Section 2.6.3.=20 'local' is strictly speaking a non-POSIX extension, but is very widely implemented (for instance, it is one of the few extensions allowed by Debian's policy[0], and seems also supported by FreeBSD's /bin/sh [1]). If the script would be significanly more burdensome if expressed without 'local', it would IMHO make sense to at least contemplate the issue. [0] http://www.debian.org/doc/debian-policy/ch-files.html#s-scripts [1] http://www.freebsd.org/cgi/man.cgi?query=3Dsh&format=3Dhtml Regards, Rotty --=20 Andreas Rottmann --