* Re: "avoid running GC when SCM_I_CURRENT_THREAD is unset"
[not found] <87ipv0fmof.fsf@ossau.uklinux.net>
@ 2011-03-30 21:31 ` Andy Wingo
2011-03-30 21:59 ` Neil Jerram
0 siblings, 1 reply; 2+ messages in thread
From: Andy Wingo @ 2011-03-30 21:31 UTC (permalink / raw)
To: Neil Jerram; +Cc: guile-devel
Hi Neil!
Adding guile-devel; I'm wrong a lot lately, and folks should know ;-)
On Wed 30 Mar 2011 21:11, Neil Jerram <neil@ossau.uklinux.net> writes:
> I saw this change and couldn't fully understand it. Given that you
> ended up adding GC_disable() and GC_enable() around the GC_malloc()
> call, couldn't you just have done that without all the other changes
> from "t->" to "t." ?
>
> I'm probably missing something, but could you point it out?
Indeed, I probably could have just done a GC_disable before the whole
thing, and an enable() afterwards. That's probably clearer, no?
Andy
--
http://wingolog.org/
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: "avoid running GC when SCM_I_CURRENT_THREAD is unset"
2011-03-30 21:31 ` "avoid running GC when SCM_I_CURRENT_THREAD is unset" Andy Wingo
@ 2011-03-30 21:59 ` Neil Jerram
0 siblings, 0 replies; 2+ messages in thread
From: Neil Jerram @ 2011-03-30 21:59 UTC (permalink / raw)
To: Andy Wingo; +Cc: guile-devel
Andy Wingo <wingo@pobox.com> writes:
> Hi Neil!
>
> Adding guile-devel; I'm wrong a lot lately, and folks should know ;-)
>
> On Wed 30 Mar 2011 21:11, Neil Jerram <neil@ossau.uklinux.net> writes:
>
>> I saw this change and couldn't fully understand it. Given that you
>> ended up adding GC_disable() and GC_enable() around the GC_malloc()
>> call, couldn't you just have done that without all the other changes
>> from "t->" to "t." ?
>>
>> I'm probably missing something, but could you point it out?
>
> Indeed, I probably could have just done a GC_disable before the whole
> thing, and an enable() afterwards. That's probably clearer, no?
I doubt it's worth going back, now that the change is made.
I really just wanted to make sure I understood - because I'm seeing a
problem on ARM that looks GC-related, and so was reviewing recent
GC-area changes. I'll post a bit more about that in a new thread.
Neil
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-30 21:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <87ipv0fmof.fsf@ossau.uklinux.net>
2011-03-30 21:31 ` "avoid running GC when SCM_I_CURRENT_THREAD is unset" Andy Wingo
2011-03-30 21:59 ` Neil Jerram
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).