From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Rottmann Newsgroups: gmane.lisp.guile.devel Subject: Re: [Guile-commits] GNU Guile branch, stable-2.0, updated. v2.0.1-40-g2252321 Date: Sat, 14 May 2011 19:46:50 +0200 Message-ID: <871v0118fp.fsf@gmx.at> References: <87liyhe047.fsf@gnu.org> <87pqnmb331.fsf@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1305395238 4002 80.91.229.12 (14 May 2011 17:47:18 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 14 May 2011 17:47:18 +0000 (UTC) Cc: guile-devel@gnu.org To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sat May 14 19:47:13 2011 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QLIvp-0004Oq-Bp for guile-devel@m.gmane.org; Sat, 14 May 2011 19:47:13 +0200 Original-Received: from localhost ([::1]:40130 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QLIvo-0007YU-Jl for guile-devel@m.gmane.org; Sat, 14 May 2011 13:47:12 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:46737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QLIvl-0007Xl-NL for guile-devel@gnu.org; Sat, 14 May 2011 13:47:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QLIvg-0008UO-Ei for guile-devel@gnu.org; Sat, 14 May 2011 13:47:09 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:56941) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1QLIvg-0008U9-2n for guile-devel@gnu.org; Sat, 14 May 2011 13:47:04 -0400 Original-Received: (qmail invoked by alias); 14 May 2011 17:47:02 -0000 Original-Received: from 85-127-56-179.dynamic.xdsl-line.inode.at (EHLO nathot.lan) [85.127.56.179] by mail.gmx.net (mp001) with SMTP; 14 May 2011 19:47:02 +0200 X-Authenticated: #3102804 X-Provags-ID: V01U2FsdGVkX18AiixpbR8ASiQ+qhbRgDAmKMqNlcihUssTFqs9SN OY0gEARcqmC83G Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by nathot.lan (Postfix) with ESMTP id 150BA3A69B; Sat, 14 May 2011 19:47:00 +0200 (CEST) Original-Received: from nathot.lan ([127.0.0.1]) by localhost (nathot.lan [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eifpze2kfptE; Sat, 14 May 2011 19:46:51 +0200 (CEST) Original-Received: from delenn.lan (delenn.lan [192.168.3.11]) by nathot.lan (Postfix) with ESMTP id 1C6793A68F; Sat, 14 May 2011 19:46:51 +0200 (CEST) Original-Received: by delenn.lan (Postfix, from userid 1000) id D806A2C0086; Sat, 14 May 2011 19:46:50 +0200 (CEST) In-Reply-To: <87pqnmb331.fsf@gmx.at> (Andreas Rottmann's message of "Sat, 14 May 2011 01:20:02 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 213.165.64.23 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:12491 Archived-At: Andreas Rottmann writes: > ludo@gnu.org (Ludovic Court=C3=A8s) writes: > >> Hi Andreas, >> >> Thanks for taking care of this, and thanks for the great doc too! >> >> "Andreas Rottmann" writes: >> >>> commit 2252321bb77fe83d98d5bcc9db1c76b914e9dd6a >>> Author: Andreas Rottmann >>> Date: Sat May 7 23:40:14 2011 +0200 >>> >>> Make the R6RS simple I/O library use conditions >>>=20=20=20=20=20 >>> * module/rnrs/io/ports.scm (display): Implement as an >>> exception-converting wrapper around Guile's core display. >>> * module/rnrs/io/simple.scm: Don't export Guile's corresponding core >>> procedures, but use `(rnrs io ports)' instead. This way, we get = the >>> conditions required by R6RS raised. >>>=20=20=20=20=20 >>> * doc/ref/r6rs.texi (rnrs io simple): Mention that these procedures= are >>> supposed to raise R6RS conditions. >> >> Could you add one or more test cases? >> > I've started to hack on this, aiming for at least providing tests of a > "control sample" of exception-related behaviors in `(rnrs io simple)' > and parts of `(rnrs io ports)'. However, as this is already > significantly more than one test, it may take a bit. I could however > push my existing work at any point, if that's needed for any reason. > I've now pushed a first patch (b6a66c2), in the process fixing two bugs. These were not directly related to the simple I/O change you referenced, but located in its base library `(rnrs io ports)'. There's still more to come in that area: - Tests for en/decoding error behavior. - Fixing `get-string-n!' to raise proper conditions. This also entails introducing an extension to scm_getc() which communicates errors via return value or output arguments, thus speeding up `get-char'. I'll post a patch for review once I have something worth showing. I think we are approaching completeness and correctness of our R6RS I/O support -- besides Section 8.2.13 "Input/output ports" and the EOL handling, I'm not aware of major stuff missing. Regards, Rotty --=20 Andreas Rottmann --