unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Mark H Weaver <mhw@netris.org>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH] Implement ‘hash’ for structs
Date: Fri, 12 Oct 2012 23:48:36 +0200	[thread overview]
Message-ID: <871uh3tl8r.fsf@gnu.org> (raw)
In-Reply-To: <874nm1i2oa.fsf@tines.lan> (Mark H. Weaver's message of "Thu, 11 Oct 2012 09:00:37 -0400")

Mark H Weaver <mhw@netris.org> skribis:

> ludo@gnu.org (Ludovic Courtès) writes:
>
>> Mark H Weaver <mhw@netris.org> skribis:
>>
>>> I guess this 'if' is to avoid an infinite loop if the struct points back
>>> to itself.  However, it apparently fails to detect cycles in the general
>>> case.
>>
>> Yes, indeed.
>>
>> Here’s an updated patch that uses the ‘depth’ argument of ‘scm_hasher’
>> for that, as is done for pairs.
>
> I don't think 'depth' is an appropriate name for that argument.

I’ve finally pushed it (keeping that variable name).

Thanks for the review!

Ludo’.



      parent reply	other threads:[~2012-10-12 21:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-09 22:43 [PATCH] Implement ‘hash’ for structs Ludovic Courtès
2012-10-10  2:59 ` Mark H Weaver
2012-10-10 20:36   ` Ludovic Courtès
2012-10-11 13:00     ` Mark H Weaver
2012-10-11 14:24       ` Ludovic Courtès
2012-10-12 21:48       ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871uh3tl8r.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guile-devel@gnu.org \
    --cc=mhw@netris.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).