From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Do not scan for coding declarations in open-file Date: Thu, 31 Jan 2013 21:04:07 +0100 Message-ID: <871ud1qfuw.fsf@pobox.com> References: <87zk0dq6sb.fsf@tines.lan> <8738y2x04e.fsf@gnu.org> <87zk01v45b.fsf@pobox.com> <878v7ahrfz.fsf_-_@tines.lan> <87mwvpwu2b.fsf@pobox.com> <87d2wlgoxg.fsf@tines.lan> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1359662655 19765 80.91.229.3 (31 Jan 2013 20:04:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 31 Jan 2013 20:04:15 +0000 (UTC) Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , guile-devel@gnu.org To: Mark H Weaver Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Thu Jan 31 21:04:35 2013 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U10N9-0006T7-AO for guile-devel@m.gmane.org; Thu, 31 Jan 2013 21:04:35 +0100 Original-Received: from localhost ([::1]:48279 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U10Mq-0001HZ-Sy for guile-devel@m.gmane.org; Thu, 31 Jan 2013 15:04:16 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:47859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U10Mo-0001Gc-B8 for guile-devel@gnu.org; Thu, 31 Jan 2013 15:04:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U10Mn-0002Yy-1l for guile-devel@gnu.org; Thu, 31 Jan 2013 15:04:14 -0500 Original-Received: from a-pb-sasl-quonix.pobox.com ([208.72.237.25]:56591 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U10Mm-0002Yh-Ng; Thu, 31 Jan 2013 15:04:12 -0500 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 8C550C970; Thu, 31 Jan 2013 15:04:10 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=8h6K56nArfWxQ7tW0QY+hddCyzo=; b=q2P2u+ 7ggK6Gyl+p3PI3rIIcmxoiOPJOEwR/veoCWYKJpG6MnRN0nBmgFw64+e4GDjTnJP hA8IgWFl9Gv1XsyvTnxBpZHsZmz723EnvO8ll4l4wfx8tFmozwn9H7gKMbAbwfYG 0MbdjMu1xbd5vafa7lZ/dhSM/Cxw/DXQOL59E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=A+u2tQ8dfOGpgGLna0ZIwENmlU4HfTeH Qi28uWCz2mMtRe4ihiT2UV7xIpPydrR5eDHlGmgs0JKHF0lNAWO2R6+RS6LwU2AK /yCaphtSy7tvFRSeaeISu1CwTbBfsyQLnoxJfTkSNem0yiRbTm90FXgrW5zoZjSx KyqAIOWPL4s= Original-Received: from a-pb-sasl-quonix.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 8341EC96F; Thu, 31 Jan 2013 15:04:10 -0500 (EST) Original-Received: from badger (unknown [88.160.190.192]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 02363C96C; Thu, 31 Jan 2013 15:04:09 -0500 (EST) In-Reply-To: <87d2wlgoxg.fsf@tines.lan> (Mark H. Weaver's message of "Thu, 31 Jan 2013 13:58:19 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) X-Pobox-Relay-ID: 604365CA-6BE1-11E2-943A-0A4F0E5B5709-02397024!a-pb-sasl-quonix.pobox.com X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 208.72.237.25 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:15658 Archived-At: On Thu 31 Jan 2013 19:58, Mark H Weaver writes: >> My instinct is that we should not merge this patch without including a >> way to enable the coding sniff; which seems to mean adding keywords or >> somehow extending the arguments of: >> >> open-file >> with-input-from-file >> with-output-to-file >> call-with-output-file >> call-with-input-file >> open-input-file > > I'd be glad to do this. I've long wanted these to accept keyword > arguments for encoding and binary mode. We could also have a keyword to > ask Guile to guess the encoding. This could be used to simplify the > code used in 'compile-file' etc. > > We could also add a fluid to specify whether 'open-file' should try to > guess the encoding, if that helps. > > What do you think? Sounds great to me :) I would add the parameter only if you think it makes sense as an interface going forward -- i.e. I wouldn't add it if it's only useful for the rest of the life of the 2.0.x series. Cheers, Andy -- http://wingolog.org/