Re: [PATCH] Do not scan for coding declarations in open-file

[Andy Wingo <wingo@pobox.com>]

On Thu 31 Jan 2013 19:58, Mark H Weaver <mhw@netris.org> writes:

>> My instinct is that we should not merge this patch without including a
>> way to enable the coding sniff; which seems to mean adding keywords or
>> somehow extending the arguments of:
>>
>>   open-file
>>   with-input-from-file
>>   with-output-to-file
>>   call-with-output-file
>>   call-with-input-file
>>   open-input-file
>
> I'd be glad to do this.  I've long wanted these to accept keyword
> arguments for encoding and binary mode.  We could also have a keyword to
> ask Guile to guess the encoding.  This could be used to simplify the
> code used in 'compile-file' etc.
>
> We could also add a fluid to specify whether 'open-file' should try to
> guess the encoding, if that helps.
>
> What do you think?

Sounds great to me :)

I would add the parameter only if you think it makes sense as an
interface going forward -- i.e. I wouldn't add it if it's only useful
for the rest of the life of the 2.0.x series.

Cheers,

Andy
-- 
http://wingolog.org/