From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Fix tree-il code generation for ECMAscript `new' expression. Date: Tue, 25 Oct 2016 23:41:11 +0200 Message-ID: <871sz4yumg.fsf@gnu.org> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1477431747 29994 195.159.176.226 (25 Oct 2016 21:42:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 25 Oct 2016 21:42:27 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Tue Oct 25 23:42:20 2016 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bz9Tz-0005ZW-A0 for guile-devel@m.gmane.org; Tue, 25 Oct 2016 23:42:07 +0200 Original-Received: from localhost ([::1]:58407 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bz9U1-0003qC-Q0 for guile-devel@m.gmane.org; Tue, 25 Oct 2016 17:42:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bz9Tj-0003pl-Iq for guile-devel@gnu.org; Tue, 25 Oct 2016 17:41:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bz9Te-0005gV-My for guile-devel@gnu.org; Tue, 25 Oct 2016 17:41:51 -0400 Original-Received: from [195.159.176.226] (port=44199 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bz9Te-0005g9-GC for guile-devel@gnu.org; Tue, 25 Oct 2016 17:41:46 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1bz9TT-0001wR-VL for guile-devel@gnu.org; Tue, 25 Oct 2016 23:41:35 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 19 Original-X-Complaints-To: usenet@blaine.gmane.org X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 4 Brumaire an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Cancel-Lock: sha1:CTg8Uk3XrQURDg3+aghLCmCwEhA= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.org gmane.lisp.guile.devel:18733 Archived-At: Julian Graham skribis: > From 16ef2df6cc206f829c3aff96b1b315ed6fb50c05 Mon Sep 17 00:00:00 2001 > From: Julian Graham > Date: Tue, 13 Sep 2016 08:39:43 -0400 > Subject: [PATCH] Fix tree-il code generation for ECMAscript `new' expression. > > The compiler was producing `((toplevel foo))' instead of `(toplevel foo)'. > Changed to use `call' form with target type and spliced constructor > arguments. > > * module/language/ecmascript/compile-tree-il.scm (comp): Replace `@impl' > shorthand with `call' + `@implv' for better control over resulting > tree-il. > * test-suite/tests/ecmascript.test (compiler): Add test for "new Object();" Finally pushed to master, thanks! :-) Ludo’.