From: Eli Zaretskii <eliz@gnu.org>
To: ludo@gnu.org (Ludovic Courtès)
Cc: guile-devel@gnu.org
Subject: Re: Bug in scm_getaffinity
Date: Thu, 03 Jul 2014 19:31:15 +0300 [thread overview]
Message-ID: <83zjgq1k18.fsf@gnu.org> (raw)
In-Reply-To: <87simjeal5.fsf@gnu.org>
> From: ludo@gnu.org (Ludovic Courtès)
> Cc: guile-devel@gnu.org
> Date: Wed, 02 Jul 2014 23:04:38 +0200
>
> > static SCM
> > cpu_set_to_bitvector (const cpu_set_t *cs)
> > {
> > SCM bv;
> > size_t cpu;
> >
> > bv = scm_c_make_bitvector (sizeof (*cs), SCM_BOOL_F);
> >
> > for (cpu = 0; cpu < sizeof (*cs); cpu++)
> > {
> > if (CPU_ISSET (cpu, cs))
> > /* XXX: This is inefficient but avoids code duplication. */
> > scm_c_bitvector_set_x (bv, cpu, SCM_BOOL_T);
> > }
> >
> > I think using 'sizeof (*cs)' is incorrect here, we need to use
> > CPU_SETSIZE instead. The cpu_set_t data type could be an array of bit
> > masks, in which case counting only bytes in it is wrong: the result is
> > too small.
>
> Indeed, good catch. Could you commit the obvious fix?
Done.
prev parent reply other threads:[~2014-07-03 16:31 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-08 15:04 MinGW issues in Guile 2.0.11 Eli Zaretskii
2014-06-09 15:47 ` Eli Zaretskii
2014-06-09 18:01 ` Mark H Weaver
2014-06-09 18:25 ` Eli Zaretskii
2014-06-09 19:30 ` MinGW vs. setlocale Ludovic Courtès
2014-06-10 16:17 ` Eli Zaretskii
2014-06-11 13:13 ` Ludovic Courtès
2014-06-11 15:33 ` Eli Zaretskii
2014-06-12 8:39 ` Ludovic Courtès
2014-06-12 18:18 ` Eli Zaretskii
2014-06-15 17:23 ` Eli Zaretskii
2014-06-21 11:17 ` Eli Zaretskii
2014-06-21 15:02 ` Ludovic Courtès
2014-06-21 15:11 ` Eli Zaretskii
2014-06-21 21:23 ` Ludovic Courtès
2014-06-22 16:13 ` Eli Zaretskii
2014-06-19 4:53 ` Doug Evans
2014-06-19 8:16 ` Ludovic Courtès
2014-06-09 19:32 ` MinGW vs. c-api.test Ludovic Courtès
2014-06-10 9:05 ` Neil Jerram
2014-06-10 11:42 ` Ludovic Courtès
2014-06-10 15:32 ` Eli Zaretskii
2014-06-10 15:56 ` David Kastrup
2014-06-10 18:00 ` Eli Zaretskii
2014-06-11 0:36 ` dsmich
2014-06-11 2:52 ` Eli Zaretskii
2014-06-10 11:44 ` Ludovic Courtès
2014-06-10 15:39 ` Eli Zaretskii
2014-06-11 12:37 ` Ludovic Courtès
2014-06-11 15:08 ` Eli Zaretskii
2014-06-12 8:29 ` Ludovic Courtès
2014-06-12 17:16 ` Eli Zaretskii
2014-06-12 19:48 ` Ludovic Courtès
2014-06-12 19:59 ` Eli Zaretskii
2014-06-12 21:20 ` Ludovic Courtès
2014-06-13 9:15 ` Neil Jerram
2014-06-13 16:04 ` Ludovic Courtès
2014-06-13 16:19 ` Eli Zaretskii
2014-06-13 16:26 ` Neil Jerram
2014-06-13 16:31 ` Mike Gerwitz
2014-06-13 18:09 ` Eli Zaretskii
2014-06-09 19:42 ` Windows file name separators Ludovic Courtès
2014-06-10 16:00 ` Eli Zaretskii
2014-06-30 11:15 ` Ludovic Courtès
2014-06-30 14:56 ` Eli Zaretskii
2014-07-01 9:36 ` Ludovic Courtès
2014-07-01 15:30 ` Eli Zaretskii
2014-07-01 15:38 ` Ludovic Courtès
2014-07-02 16:04 ` Eli Zaretskii
2014-07-02 20:56 ` Ludovic Courtès
2014-07-02 20:57 ` Ludovic Courtès
2014-07-03 15:10 ` Eli Zaretskii
2014-07-03 17:11 ` Ludovic Courtès
2014-07-03 18:09 ` Eli Zaretskii
2014-07-07 20:53 ` Mark H Weaver
2014-07-08 2:37 ` Eli Zaretskii
2014-07-02 16:13 ` Fix 'dirname' and 'basename' on MS-Windows Eli Zaretskii
2014-07-09 14:22 ` Ludovic Courtès
2014-07-09 14:53 ` Eli Zaretskii
2014-07-02 16:16 ` Provide reasonable stack limit " Eli Zaretskii
2014-07-02 21:02 ` Ludovic Courtès
2014-07-03 16:28 ` Eli Zaretskii
2014-07-02 16:30 ` Bug in scm_getaffinity Eli Zaretskii
2014-07-02 21:04 ` Ludovic Courtès
2014-07-03 16:31 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zjgq1k18.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=guile-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).