From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.lisp.guile.devel Subject: Re: Support open-process and friends on MS-Windows Date: Sat, 25 Jun 2016 13:22:08 +0300 Message-ID: <83y45tzhyn.fsf@gnu.org> References: <834m8i3off.fsf@gnu.org> <877fde958i.fsf@gnu.org> <83wple1zym.fsf@gnu.org> <83ziq9zl8l.fsf@gnu.org> <87eg7lbnpi.fsf@pobox.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1466850199 18493 80.91.229.3 (25 Jun 2016 10:23:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 25 Jun 2016 10:23:19 +0000 (UTC) Cc: ludo@gnu.org, guile-devel@gnu.org To: Andy Wingo Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sat Jun 25 12:23:14 2016 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bGkk5-0005FJ-Hf for guile-devel@m.gmane.org; Sat, 25 Jun 2016 12:23:13 +0200 Original-Received: from localhost ([::1]:49238 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGkk4-0008FI-HR for guile-devel@m.gmane.org; Sat, 25 Jun 2016 06:23:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57803) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGkjr-0008F1-1w for guile-devel@gnu.org; Sat, 25 Jun 2016 06:22:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGkjo-0004sf-Ve for guile-devel@gnu.org; Sat, 25 Jun 2016 06:22:57 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGkjk-0004nn-6G; Sat, 25 Jun 2016 06:22:52 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4829 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bGkji-0002FI-0Q; Sat, 25 Jun 2016 06:22:50 -0400 In-reply-to: <87eg7lbnpi.fsf@pobox.com> (message from Andy Wingo on Sat, 25 Jun 2016 11:51:53 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.org gmane.lisp.guile.devel:18430 Archived-At: > From: Andy Wingo > Cc: ludo@gnu.org, guile-devel@gnu.org > Date: Sat, 25 Jun 2016 11:51:53 +0200 > > On Sat 25 Jun 2016 11:11, Eli Zaretskii writes: > > > Here's the modified patch with the couple of changes requested in > > response to the previous version: > > Great! I have two nits. One, if it is possible for you, please attach > the patch in the format that "git format-patch" makes. That makes it > easy to apply, otherwise I have to futz around with --author and I could > accidentally fat-finger it and get it wrong. > > Secondly, please make w32-proc override the definitions of > HAVE_GETPRIORITY, HAVE_SETPRIORITY, HAVE_SCHED_GETAFFINITY, and > HAVE_SCHED_SETAFFINITY. That way you won't need this kind of change > either: > > > -#if HAVE_GETPRIORITY > > +#if HAVE_GETPRIORITY || defined __MINGW32__ > > If you've already discussed this with Ludovic and decided to go this way > explicitly, please disregard this second nit. > > I will also wait a day or two for any comments from Ludovic before > applying. Thanks, I will wait for Ludovic to tell he's okay with overriding the HAVE_* macros, and will send a format-patch formatted changes after that.