From: Eli Zaretskii <eliz@gnu.org>
To: Andy Wingo <wingo@pobox.com>
Cc: ludo@gnu.org, guile-devel@gnu.org
Subject: Re: Support open-process and friends on MS-Windows
Date: Sat, 25 Jun 2016 13:22:08 +0300 [thread overview]
Message-ID: <83y45tzhyn.fsf@gnu.org> (raw)
In-Reply-To: <87eg7lbnpi.fsf@pobox.com> (message from Andy Wingo on Sat, 25 Jun 2016 11:51:53 +0200)
> From: Andy Wingo <wingo@pobox.com>
> Cc: ludo@gnu.org, guile-devel@gnu.org
> Date: Sat, 25 Jun 2016 11:51:53 +0200
>
> On Sat 25 Jun 2016 11:11, Eli Zaretskii <eliz@gnu.org> writes:
>
> > Here's the modified patch with the couple of changes requested in
> > response to the previous version:
>
> Great! I have two nits. One, if it is possible for you, please attach
> the patch in the format that "git format-patch" makes. That makes it
> easy to apply, otherwise I have to futz around with --author and I could
> accidentally fat-finger it and get it wrong.
>
> Secondly, please make w32-proc override the definitions of
> HAVE_GETPRIORITY, HAVE_SETPRIORITY, HAVE_SCHED_GETAFFINITY, and
> HAVE_SCHED_SETAFFINITY. That way you won't need this kind of change
> either:
>
> > -#if HAVE_GETPRIORITY
> > +#if HAVE_GETPRIORITY || defined __MINGW32__
>
> If you've already discussed this with Ludovic and decided to go this way
> explicitly, please disregard this second nit.
>
> I will also wait a day or two for any comments from Ludovic before
> applying.
Thanks, I will wait for Ludovic to tell he's okay with overriding the
HAVE_* macros, and will send a format-patch formatted changes after
that.
next prev parent reply other threads:[~2016-06-25 10:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 9:51 Support open-process and friends on MS-Windows Eli Zaretskii
2016-06-24 10:45 ` Andy Wingo
2016-06-24 13:20 ` Eli Zaretskii
2016-06-24 11:49 ` Ludovic Courtès
2016-06-24 13:25 ` Eli Zaretskii
2016-06-25 9:11 ` Eli Zaretskii
2016-06-25 9:51 ` Andy Wingo
2016-06-25 10:22 ` Eli Zaretskii [this message]
2016-06-25 13:02 ` Ludovic Courtès
2016-06-25 13:20 ` Eli Zaretskii
2016-06-25 13:31 ` Eli Zaretskii
2016-06-25 14:43 ` Andy Wingo
2016-06-25 15:01 ` Eli Zaretskii
2016-07-02 23:02 ` Mark H Weaver
2016-07-03 3:47 ` Eli Zaretskii
2016-07-03 17:36 ` Eli Zaretskii
2016-07-05 7:44 ` Mark H Weaver
2016-07-05 8:04 ` Ludovic Courtès
2016-07-05 15:56 ` Eli Zaretskii
2016-07-11 8:09 ` Ludovic Courtès
2016-07-11 14:49 ` Eli Zaretskii
2016-07-05 15:51 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y45tzhyn.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=guile-devel@gnu.org \
--cc=ludo@gnu.org \
--cc=wingo@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).