unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: ludo@gnu.org (Ludovic Courtès)
Cc: guile-devel@gnu.org
Subject: Re: Link failure on systems lacking mkstemp
Date: Fri, 30 Oct 2015 17:19:04 +0200	[thread overview]
Message-ID: <83twp8z8nr.fsf@gnu.org> (raw)
In-Reply-To: <87eggcif14.fsf@gnu.org>

> From: ludo@gnu.org (Ludovic Courtès)
> Cc: guile-devel <guile-devel@gnu.org>
> Date: Fri, 30 Oct 2015 15:53:27 +0100
> 
> Eli Zaretskii <eliz@gnu.org> skribis:
> 
> > Guile 2.0.11 has mkstemp.c in lib/, from Gnulib, and it also has its
> > own private version in libguile/.  This causes link failures on
> > systems, such as MinGW, that lack mkstemp in their system libraries:
> >
> >        CCLD     libguile-2.0.la
> >      ../lib/.libs/libgnu.a(mkstemp.o): In function `mkstemp':
> >      d:\gnu\guile-2.0.11\lib/mkstemp.c:48: multiple definition of `mkstemp'
> >      .libs/libguile_2.0_la-mkstemp.o:d:\gnu\guile-2.0.11\libguile/mkstemp.c:68: first defined here
> >      collect2.exe: error: ld returned 1 exit status
> >      Makefile:2242: recipe for target `libguile-2.0.la' failed
> >      make[3]: *** [libguile-2.0.la] Error 1
> >      make[3]: Leaving directory `/d/gnu/guile-2.0.11/libguile'
> >      Makefile:2162: recipe for target `all' failed
> >
> > I think the solution is simply remove mkstemp.c from libguile/, and
> > all its traces from the configury that causes its dependency to be
> > added to libguile/Makefile.  Not sure how to do the latter, though.
> 
> I’m ashamed of the delay but hey, better late than never.
> 
> This bug was reported independently at <http://bugs.gnu.org/21425> and a
> fix was committed just yesterday, along the lines of what you suggested
> (see commit efd8a43.)  Let me know what you think.

Thanks, looks good.




      reply	other threads:[~2015-10-30 15:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-16 11:42 Link failure on systems lacking mkstemp Eli Zaretskii
2014-08-16 14:49 ` Eli Zaretskii
2014-08-29  8:30   ` Eli Zaretskii
2014-09-15 17:15     ` Eli Zaretskii
2014-08-29  8:29 ` Eli Zaretskii
2014-09-15 17:14   ` Eli Zaretskii
2015-10-30 14:53 ` Ludovic Courtès
2015-10-30 15:19   ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83twp8z8nr.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=guile-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).