From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.lisp.guile.devel Subject: Don't skip popen.test on MinGW Date: Sun, 29 Jun 2014 19:09:51 +0300 Message-ID: <83mwcv66k0.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1404058229 13672 80.91.229.3 (29 Jun 2014 16:10:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 29 Jun 2014 16:10:29 +0000 (UTC) Cc: ludo@gnu.org, guile-devel@gnu.org To: Mark H Weaver Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sun Jun 29 18:10:22 2014 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X1HgL-0000sK-Qu for guile-devel@m.gmane.org; Sun, 29 Jun 2014 18:10:21 +0200 Original-Received: from localhost ([::1]:58227 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1HgL-0006yQ-An for guile-devel@m.gmane.org; Sun, 29 Jun 2014 12:10:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1Hg8-0006uH-RF for guile-devel@gnu.org; Sun, 29 Jun 2014 12:10:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X1Hg1-0005cA-DL for guile-devel@gnu.org; Sun, 29 Jun 2014 12:10:08 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:42636) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1Hg1-0005c4-4q; Sun, 29 Jun 2014 12:10:01 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0N7X00C00U3IR000@a-mtaout22.012.net.il>; Sun, 29 Jun 2014 19:10:00 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N7X00CVGU8NDQ90@a-mtaout22.012.net.il>; Sun, 29 Jun 2014 19:09:59 +0300 (IDT) X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.172 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:17243 Archived-At: Another issue related to open-process is that popen.test was being skipped because if-supported returns #f. I fixed it thusly: (define-syntax-rule (if-supported body ...) (if (or (provided? 'fork) ((string-contains %host-type "-mingw32"))) (begin body ...))) Is this OK? Again, perhaps the test should be removed, and popen.test should be run unconditionally?