From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.lisp.guile.devel Subject: Re: MinGW vs. setlocale Date: Sat, 21 Jun 2014 18:11:31 +0300 Message-ID: <83d2e2thzw.fsf@gnu.org> References: <83lht730k8.fsf@gnu.org> <8761k97ue1.fsf@gnu.org> <83d2eg20z9.fsf@gnu.org> <87ppifmvvt.fsf@gnu.org> <83fvjbzcjd.fsf@gnu.org> <87oaxyjzdf.fsf@gnu.org> <83fvjaxa7o.fsf@gnu.org> <83ppiaulx6.fsf@gnu.org> <87a996i9vd.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: ger.gmane.org 1403363527 30012 80.91.229.3 (21 Jun 2014 15:12:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 21 Jun 2014 15:12:07 +0000 (UTC) Cc: guile-devel@gnu.org To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sat Jun 21 17:12:01 2014 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WyMxV-0002EO-7W for guile-devel@m.gmane.org; Sat, 21 Jun 2014 17:12:01 +0200 Original-Received: from localhost ([::1]:45466 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WyMxU-0001k5-Oj for guile-devel@m.gmane.org; Sat, 21 Jun 2014 11:12:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WyMxL-0001aS-WE for guile-devel@gnu.org; Sat, 21 Jun 2014 11:11:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WyMxD-0000P8-7b for guile-devel@gnu.org; Sat, 21 Jun 2014 11:11:51 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:34400) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WyMxC-0000OR-PY; Sat, 21 Jun 2014 11:11:43 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0N7I00H00XRP1L00@a-mtaout22.012.net.il>; Sat, 21 Jun 2014 18:11:41 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N7I00G45Y7HN180@a-mtaout22.012.net.il>; Sat, 21 Jun 2014 18:11:41 +0300 (IDT) In-reply-to: <87a996i9vd.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.172 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:17232 Archived-At: > From: ludo@gnu.org (Ludovic Court=C3=A8s) > Cc: guile-devel@gnu.org > Date: Sat, 21 Jun 2014 17:02:30 +0200 >=20 > Hi Eli, >=20 > (Sorry for the delay, I switched contexts, and I=E2=80=99m not usin= g fair > scheduling I suppose. ;-)) No sweat. > > --- libguile/i18n.c~2=092014-06-15 14:21:53 +0300 > > +++ libguile/i18n.c=092014-06-15 14:58:09 +0300 > > @@ -1583,9 +1583,13 @@ SCM_DEFINE (scm_nl_langinfo, "nl-langinf > > =09 } > > #endif > > =20 > > -#if (defined FRAC_DIGITS) && (defined INT_FRAC_DIGITS) > > +#if defined FRAC_DIGITS || defined INT_FRAC_DIGITS > > +#ifdef FRAC_DIGITS > > =09case FRAC_DIGITS: > > +#endif > > +#ifdef INT_FRAC_DIGITS > > =09case INT_FRAC_DIGITS: > > +#endif > > =09 /* This is to be interpreted as a single integer. */ > > =09 if (*c_result =3D=3D CHAR_MAX) > > =09 /* Unspecified. */ > > @@ -1597,12 +1601,18 @@ SCM_DEFINE (scm_nl_langinfo, "nl-langinf > > =09 break; > > #endif > > =20 > > -#if (defined P_CS_PRECEDES) && (defined INT_N_CS_PRECEDES) > > +#if defined P_CS_PRECEDES || defined N_CS_PRECEDES ||=09\ > > + defined INT_P_CS_PRECEDES || defined INT_N_CS_PRECEDES || \ > > + defined P_SEP_BY_SPACE || defined N_SEP_BY_SPACE > > +#ifdef P_CS_PRECEDES > > =09case P_CS_PRECEDES: > > =09case N_CS_PRECEDES: > > +#endif > > +#ifdef INT_N_CS_PRECEDES > > =09case INT_P_CS_PRECEDES: > > =09case INT_N_CS_PRECEDES: > > -#if (defined P_SEP_BY_SPACE) && (defined N_SEP_BY_SPACE) > > +#endif > > +#ifdef P_SEP_BY_SPACE > > =09case P_SEP_BY_SPACE: > > =09case N_SEP_BY_SPACE: > > #endif > > @@ -1613,11 +1623,16 @@ SCM_DEFINE (scm_nl_langinfo, "nl-langinf > > =09 break; > > #endif > > =20 > > -#if (defined P_SIGN_POSN) && (defined INT_N_SIGN_POSN) > > +#if defined P_SIGN_POSN || defined N_SIGN_POSN || \ > > + defined INT_P_SIGN_POSN || defined INT_N_SIGN_POSN > > +#ifdef P_SIGN_POSN > > =09case P_SIGN_POSN: > > =09case N_SIGN_POSN: > > +#endif > > +#ifdef INT_P_SIGN_POSN > > =09case INT_P_SIGN_POSN: > > =09case INT_N_SIGN_POSN: > > +#endif > > =09 /* See `(libc) Sign of Money Amount' for the interpretation= of the > > =09 return value here. */ > > =09 switch (*c_result) >=20 > This change looks OK to me. Can you commit it yourself? Yes. Just to be sure: I should commit it to the stable-2.0 branch, right? > Note that we don=E2=80=99t have ChangeLog files. Instead, we write > ChangeLog-style commit logs. Please see previous commit logs to ge= t an > idea. Will do. > PS: I still have a bunch of messages from you marked as to be proce= ssed. > I=E2=80=99ll try to get back to it ASAP. Thanks.