From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.lisp.guile.devel Subject: Re: Don't skip popen.test on MinGW Date: Mon, 30 Jun 2014 17:51:29 +0300 Message-ID: <8361ji5u32.fsf@gnu.org> References: <83mwcv66k0.fsf@gnu.org> <8761ji3b6t.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: ger.gmane.org 1404139948 9098 80.91.229.3 (30 Jun 2014 14:52:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 30 Jun 2014 14:52:28 +0000 (UTC) Cc: mhw@netris.org, guile-devel@gnu.org To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Jun 30 16:52:22 2014 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X1cwN-0002j8-PC for guile-devel@m.gmane.org; Mon, 30 Jun 2014 16:52:19 +0200 Original-Received: from localhost ([::1]:34843 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1cwN-0005x5-Dm for guile-devel@m.gmane.org; Mon, 30 Jun 2014 10:52:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1cvm-0005Ke-Me for guile-devel@gnu.org; Mon, 30 Jun 2014 10:51:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X1cvg-0000iz-Qw for guile-devel@gnu.org; Mon, 30 Jun 2014 10:51:42 -0400 Original-Received: from mtaout24.012.net.il ([80.179.55.180]:36190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1cvg-0000io-DA; Mon, 30 Jun 2014 10:51:36 -0400 Original-Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0N7Z00C00KYDEF00@mtaout24.012.net.il>; Mon, 30 Jun 2014 17:47:42 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N7Z009QEL3II930@mtaout24.012.net.il>; Mon, 30 Jun 2014 17:47:42 +0300 (IDT) In-reply-to: <8761ji3b6t.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.180 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:17252 Archived-At: > From: ludo@gnu.org (Ludovic Court=C3=A8s) > Cc: Mark H Weaver , guile-devel@gnu.org > Date: Mon, 30 Jun 2014 13:10:18 +0200 >=20 > Eli Zaretskii skribis: >=20 > > Another issue related to open-process is that popen.test was bein= g > > skipped because if-supported returns #f. I fixed it thusly: > > > > (define-syntax-rule (if-supported body ...) > > (if (or (provided? 'fork) > > =09 ((string-contains %host-type "-mingw32"))) > > =09 (begin body ...))) > > > > Is this OK? Again, perhaps the test should be removed, and popen= .test > > should be run unconditionally? >=20 > =E2=80=98if-supported=E2=80=99 was also added when addressing MinGW= issues as part of > . >=20 > For now I think it=E2=80=99s best to change it to: >=20 > (define-syntax-rule (if-supported body ...) > (begin body ...)) Will do that as well, thanks.