From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.lisp.guile.devel Subject: Re: Don't skip popen.test on MinGW Date: Thu, 03 Jul 2014 19:22:49 +0300 Message-ID: <8338ei2yzq.fsf@gnu.org> References: <83mwcv66k0.fsf@gnu.org> <8761ji3b6t.fsf@gnu.org> <8361ji5u32.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: ger.gmane.org 1404404619 6245 80.91.229.3 (3 Jul 2014 16:23:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 3 Jul 2014 16:23:39 +0000 (UTC) Cc: mhw@netris.org, guile-devel@gnu.org To: ludo@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Thu Jul 03 18:23:32 2014 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X2jn6-0007OO-Qs for guile-devel@m.gmane.org; Thu, 03 Jul 2014 18:23:20 +0200 Original-Received: from localhost ([::1]:60772 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2jn6-0007rW-Cx for guile-devel@m.gmane.org; Thu, 03 Jul 2014 12:23:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2jmz-0007qD-26 for guile-devel@gnu.org; Thu, 03 Jul 2014 12:23:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X2jmt-0006P5-6f for guile-devel@gnu.org; Thu, 03 Jul 2014 12:23:12 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:60880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2jms-0006Of-Md; Thu, 03 Jul 2014 12:23:07 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0N8500H0096TPP00@a-mtaout21.012.net.il>; Thu, 03 Jul 2014 19:23:05 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N8500HGP9IHOH50@a-mtaout21.012.net.il>; Thu, 03 Jul 2014 19:23:05 +0300 (IDT) In-reply-to: <8361ji5u32.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.169 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:17282 Archived-At: > Date: Mon, 30 Jun 2014 17:51:29 +0300 > From: Eli Zaretskii > Cc: mhw@netris.org, guile-devel@gnu.org >=20 > > From: ludo@gnu.org (Ludovic Court=C3=A8s) > > Cc: Mark H Weaver , guile-devel@gnu.org > > Date: Mon, 30 Jun 2014 13:10:18 +0200 > >=20 > > Eli Zaretskii skribis: > >=20 > > > Another issue related to open-process is that popen.test was be= ing > > > skipped because if-supported returns #f. I fixed it thusly: > > > > > > (define-syntax-rule (if-supported body ...) > > > (if (or (provided? 'fork) > > > =09 ((string-contains %host-type "-mingw32"))) > > > =09 (begin body ...))) > > > > > > Is this OK? Again, perhaps the test should be removed, and pop= en.test > > > should be run unconditionally? > >=20 > > =E2=80=98if-supported=E2=80=99 was also added when addressing Min= GW issues as part of > > . > >=20 > > For now I think it=E2=80=99s best to change it to: > >=20 > > (define-syntax-rule (if-supported body ...) > > (begin body ...)) >=20 > Will do that as well, thanks. Done.