From: Eli Zaretskii <eliz@gnu.org>
To: ludo@gnu.org
Cc: mhw@netris.org, guile-devel@gnu.org
Subject: Re: Don't skip popen.test on MinGW
Date: Thu, 03 Jul 2014 19:22:49 +0300 [thread overview]
Message-ID: <8338ei2yzq.fsf@gnu.org> (raw)
In-Reply-To: <8361ji5u32.fsf@gnu.org>
> Date: Mon, 30 Jun 2014 17:51:29 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: mhw@netris.org, guile-devel@gnu.org
>
> > From: ludo@gnu.org (Ludovic Courtès)
> > Cc: Mark H Weaver <mhw@netris.org>, guile-devel@gnu.org
> > Date: Mon, 30 Jun 2014 13:10:18 +0200
> >
> > Eli Zaretskii <eliz@gnu.org> skribis:
> >
> > > Another issue related to open-process is that popen.test was being
> > > skipped because if-supported returns #f. I fixed it thusly:
> > >
> > > (define-syntax-rule (if-supported body ...)
> > > (if (or (provided? 'fork)
> > > ((string-contains %host-type "-mingw32")))
> > > (begin body ...)))
> > >
> > > Is this OK? Again, perhaps the test should be removed, and popen.test
> > > should be run unconditionally?
> >
> > ‘if-supported’ was also added when addressing MinGW issues as part of
> > <http://bugs.gnu.org/13848>.
> >
> > For now I think it’s best to change it to:
> >
> > (define-syntax-rule (if-supported body ...)
> > (begin body ...))
>
> Will do that as well, thanks.
Done.
prev parent reply other threads:[~2014-07-03 16:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-29 16:09 Don't skip popen.test on MinGW Eli Zaretskii
2014-06-30 11:10 ` Ludovic Courtès
2014-06-30 14:51 ` Eli Zaretskii
2014-07-03 16:22 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8338ei2yzq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=guile-devel@gnu.org \
--cc=ludo@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).