* Don't return file names with backslashes from search-path
@ 2014-08-14 15:28 Eli Zaretskii
2014-08-14 22:40 ` Mark H Weaver
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2014-08-14 15:28 UTC (permalink / raw)
To: guile-devel
This small patch plugs yet another hole through which Guile on Windows
could generate file names with backslashes.
OK to commit?
--- libguile/load.c~2 2014-07-03 09:58:29 +0300
+++ libguile/load.c 2014-08-14 17:28:26 +0300
@@ -657,7 +657,8 @@ search_path (SCM path, SCM filename, SCM
if (stat (buf.buf, stat_buf) == 0
&& ! (stat_buf->st_mode & S_IFDIR))
{
- result = scm_from_locale_string (buf.buf);
+ result =
+ scm_from_locale_string (scm_i_mirror_backslashes (buf.buf));
goto end;
}
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Don't return file names with backslashes from search-path
2014-08-14 15:28 Don't return file names with backslashes from search-path Eli Zaretskii
@ 2014-08-14 22:40 ` Mark H Weaver
2014-08-15 6:50 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Mark H Weaver @ 2014-08-14 22:40 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: guile-devel
Eli Zaretskii <eliz@gnu.org> writes:
> This small patch plugs yet another hole through which Guile on Windows
> could generate file names with backslashes.
>
> OK to commit?
>
> --- libguile/load.c~2 2014-07-03 09:58:29 +0300
> +++ libguile/load.c 2014-08-14 17:28:26 +0300
> @@ -657,7 +657,8 @@ search_path (SCM path, SCM filename, SCM
> if (stat (buf.buf, stat_buf) == 0
> && ! (stat_buf->st_mode & S_IFDIR))
> {
> - result = scm_from_locale_string (buf.buf);
> + result =
> + scm_from_locale_string (scm_i_mirror_backslashes (buf.buf));
> goto end;
> }
> }
Okay, please push.
Thanks!
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Don't return file names with backslashes from search-path
2014-08-14 22:40 ` Mark H Weaver
@ 2014-08-15 6:50 ` Eli Zaretskii
0 siblings, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2014-08-15 6:50 UTC (permalink / raw)
To: Mark H Weaver; +Cc: guile-devel
> From: Mark H Weaver <mhw@netris.org>
> Cc: guile-devel@gnu.org
> Date: Thu, 14 Aug 2014 18:40:19 -0400
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > This small patch plugs yet another hole through which Guile on Windows
> > could generate file names with backslashes.
> >
> > OK to commit?
> >
> > --- libguile/load.c~2 2014-07-03 09:58:29 +0300
> > +++ libguile/load.c 2014-08-14 17:28:26 +0300
> > @@ -657,7 +657,8 @@ search_path (SCM path, SCM filename, SCM
> > if (stat (buf.buf, stat_buf) == 0
> > && ! (stat_buf->st_mode & S_IFDIR))
> > {
> > - result = scm_from_locale_string (buf.buf);
> > + result =
> > + scm_from_locale_string (scm_i_mirror_backslashes (buf.buf));
> > goto end;
> > }
> > }
>
> Okay, please push.
Done.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-15 6:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-14 15:28 Don't return file names with backslashes from search-path Eli Zaretskii
2014-08-14 22:40 ` Mark H Weaver
2014-08-15 6:50 ` Eli Zaretskii
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).