From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Maxime Devos Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] web: send capitalized authorization header scheme Date: Fri, 24 Jun 2022 18:28:01 +0200 Message-ID: <69b3c07c82a6c48064439f4179f0861e601decf0.camel@telenet.be> References: <20220624160505.18005-1-aconchillo@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-J2bCZWRZBROv0+aBrjvB" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15695"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.38.3-1 To: Aleix Conchillo =?ISO-8859-1?Q?Flaqu=E9?= , guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Fri Jun 24 18:28:33 2022 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o4mAa-0003u1-Js for guile-devel@m.gmane-mx.org; Fri, 24 Jun 2022 18:28:32 +0200 Original-Received: from localhost ([::1]:50660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o4mAZ-00016Q-FI for guile-devel@m.gmane-mx.org; Fri, 24 Jun 2022 12:28:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4mAI-00011o-VC for guile-devel@gnu.org; Fri, 24 Jun 2022 12:28:14 -0400 Original-Received: from laurent.telenet-ops.be ([2a02:1800:110:4::f00:19]:48722) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o4mAF-00088z-6j for guile-devel@gnu.org; Fri, 24 Jun 2022 12:28:14 -0400 Original-Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by laurent.telenet-ops.be with bizsmtp id n4U52700U4UW6Th014U69t; Fri, 24 Jun 2022 18:28:06 +0200 In-Reply-To: <20220624160505.18005-1-aconchillo@gmail.com> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1656088086; bh=1SBw0lSBm4VyfkGn4x3RP3BF0PrYq8hFh+sL9DEXY3s=; h=Subject:From:To:Date:In-Reply-To:References; b=VO5LLCH54XvAwku318PsLOrSwl5lWf2Zyact/bq5Rt168Y34X7d9VYICRuE0yMqbV jB7D03o0OH+I4nTSTgnr/AKKDGKpGuIEoSX3UggXUO5Uhr9O4PZ/NWsSFUXdH3Uq/V lBCcoZog0Eq2dP7ydKQZvIh+hBLvvOskP0+Aa4FcI1zYsysRR6re6WF9hX4Lc/txiQ kwGRVFmVIBxyT6jX9uBo/JEVeIlGGFbd+ywpyIfQKLm6GV6FSNjV/5w8kH6uN08u5q yGri0+au8aevqZvJEZW5y4zxb4EqAFElEAJDkSZYN/TWKgOMSP6H863gjqAx7SULC/ F2hQQ89Z3ov2g== Received-SPF: pass client-ip=2a02:1800:110:4::f00:19; envelope-from=maximedevos@telenet.be; helo=laurent.telenet-ops.be X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:21238 Archived-At: --=-J2bCZWRZBROv0+aBrjvB Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Aleix Conchillo Flaqu=C3=A9 schreef op vr 24-06-2022 om 09:05 [-0700]: > * module/web/http.scm (write-credentials): capitalize authorization > header scheme. The standard allows the scheme to be case-insensitive, > however most libraries out there expect the scheme to be capitalized, > which is what it is actually used in RFC > docs (e.g. https://datatracker.ietf.org/doc/html/rfc7617#section-2). Some > libraries even reject lowercase scheme making Guile incompatible. This comment looks more useful to me to put in the source code, to help future readers of the source code, otherwise they would have to dig through the git history. As mentioned previously, this could be something like: ;; While according to RFC 7617 Schemes are case-insensitive: ;; ;; =E2=80=98Note that both scheme and parameter names are matched ;; case-insensitive=E2=80=99 ;; ;; some software (*) incorrectly assumes title case for scheme ;; names, so use the more titlecase. ;; ;; (*): See, e.g., ;; ;; which would also address the issue of not forgetting that Guile's old behaviour is correct, it's the other party that's not following the specification. Greetings, Maxime. --=-J2bCZWRZBROv0+aBrjvB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYrXmERccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hYRAQC3/J3cqWvHSjyCKWdg/eIXTcbD 1l9Bj1O5vbFTw7fiaAEA8JHCN6TIGPyBTvsXz1OHeaTudVL8ilxn9tYihJLIrQ8= =8mU7 -----END PGP SIGNATURE----- --=-J2bCZWRZBROv0+aBrjvB--