unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: "Aleix Conchillo Flaqué" <aconchillo@gmail.com>, guile-devel@gnu.org
Subject: Re: [PATCH] web: send capitalized authorization header scheme
Date: Fri, 24 Jun 2022 18:28:01 +0200	[thread overview]
Message-ID: <69b3c07c82a6c48064439f4179f0861e601decf0.camel@telenet.be> (raw)
In-Reply-To: <20220624160505.18005-1-aconchillo@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]

Aleix Conchillo Flaqué schreef op vr 24-06-2022 om 09:05 [-0700]:
> * module/web/http.scm (write-credentials): capitalize authorization
> header scheme. The standard allows the scheme to be case-insensitive,
> however most libraries out there expect the scheme to be capitalized,
> which is what it is actually used in RFC
> docs (e.g. https://datatracker.ietf.org/doc/html/rfc7617#section-2). Some
> libraries even reject lowercase scheme making Guile incompatible.

This comment looks more useful to me to put in the source code, to help
future readers of the source code, otherwise they would have to dig
through the git history.  As mentioned previously, this could be
something like:

   ;; While according to RFC 7617 Schemes are case-insensitive:
   ;;
   ;; ‘Note that both scheme and parameter names are matched
   ;; case-insensitive’
   ;;
   ;; some software (*) incorrectly assumes title case for scheme
   ;; names, so use the more titlecase.
   ;;
   ;; (*): See, e.g.,
   ;; <https://[bug report 1]/>
   ;; <https://[bug report 2]/>

which would also address the issue of not forgetting that Guile's old
behaviour is correct, it's the other party that's not following the
specification.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  reply	other threads:[~2022-06-24 16:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-24 16:05 [PATCH] web: send capitalized authorization header scheme Aleix Conchillo Flaqué
2022-06-24 16:28 ` Maxime Devos [this message]
2022-06-24 16:35   ` Aleix Conchillo Flaqué
  -- strict thread matches above, loose matches on Subject: below --
2022-06-24 16:34 Aleix Conchillo Flaqué
2022-06-24 19:51 ` Maxime Devos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69b3c07c82a6c48064439f4179f0861e601decf0.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=aconchillo@gmail.com \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).