From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mikael Djurfeldt Newsgroups: gmane.lisp.guile.devel Subject: Re: module GC bug Date: Fri, 8 Jul 2005 11:24:50 +0200 Message-ID: <66e540fe05070802241cbf85ad@mail.gmail.com> References: <42A8D188.20007@xs4all.nl> <87fyuq1mrr.fsf@zagadka.de> Reply-To: djurfeldt@nada.kth.se NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1120815611 14554 80.91.229.2 (8 Jul 2005 09:40:11 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 8 Jul 2005 09:40:11 +0000 (UTC) Cc: Mikael Djurfeldt , guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Fri Jul 08 11:40:08 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DqpKp-0003RF-DR for guile-devel@m.gmane.org; Fri, 08 Jul 2005 11:39:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DqpME-0002l6-LZ for guile-devel@m.gmane.org; Fri, 08 Jul 2005 05:41:18 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Dqp9X-0006vf-8y for guile-devel@gnu.org; Fri, 08 Jul 2005 05:28:11 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Dqp9V-0006uY-FC for guile-devel@gnu.org; Fri, 08 Jul 2005 05:28:09 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dqp9U-0006tO-O4 for guile-devel@gnu.org; Fri, 08 Jul 2005 05:28:08 -0400 Original-Received: from [64.233.170.200] (helo=rproxy.gmail.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DqpCx-0001Oz-Nj for guile-devel@gnu.org; Fri, 08 Jul 2005 05:31:43 -0400 Original-Received: by rproxy.gmail.com with SMTP id a36so337804rnf for ; Fri, 08 Jul 2005 02:24:50 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=J77nPmiF9cTx+DHvw12nGj1g5u5zIXXD5+h+fterI1JLj9zfQ7Sh7feMYyozXqZtmVqdNwKkJZRpsHfO6xdkppF0vcQSl6aF8OMciNefaS05njeYfGAHNaH91AYVPcoFyHDJNbkQjkDWT5I0vGW2DGuQH0VNZBxfxxh31npRuOE= Original-Received: by 10.38.104.28 with SMTP id b28mr1609954rnc; Fri, 08 Jul 2005 02:24:50 -0700 (PDT) Original-Received: by 10.38.104.10 with HTTP; Fri, 8 Jul 2005 02:24:50 -0700 (PDT) Original-To: Marius Vollmer In-Reply-To: <87fyuq1mrr.fsf@zagadka.de> Content-Disposition: inline X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:5142 X-Report-Spam: http://spam.gmane.org/gmane.lisp.guile.devel:5142 On 7/7/05, Marius Vollmer wrote: > > I've fixed this by introducing a new function (eval-closure-module) > > which returns the module of a closure via the eval-closure smob. >=20 > I think the right fix is to change the weak hashtable marking > algorithm to properly cope with circular references like this. I will > try this and then come back to you. (I don't know how long this might > take since the required changes look to be slightly non-trivial (but > entirely possible).) That would be good, because the current fix (which is already committed to CVS HEAD, and which removes the setting of the procedure-property) still leaves code in modules.c which expects the procedure-property to be set. If Han-Wen's fix is to be kept, then you should, at least, remove that code. The consequence is that it will no longer be possible to lookup the module of the eval closure for any kind of closures except the standard ones (which are implemented as a smob). M _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel