From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mikael Djurfeldt Newsgroups: gmane.lisp.guile.devel Subject: Re: Critical section review Date: Wed, 23 Mar 2005 09:58:21 +0100 Message-ID: <66e540fe050323005822a5d217@mail.gmail.com> References: <424125C0.7000407@ossau.uklinux.net> Reply-To: djurfeldt@nada.kth.se NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1111568694 7266 80.91.229.2 (23 Mar 2005 09:04:54 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 23 Mar 2005 09:04:54 +0000 (UTC) Cc: guile-devel Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Mar 23 10:04:53 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DE1nG-0007LJ-NW for guile-devel@m.gmane.org; Wed, 23 Mar 2005 10:04:51 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DE20j-0004KZ-0Z for guile-devel@m.gmane.org; Wed, 23 Mar 2005 04:18:45 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DE1zy-0004FB-Ky for guile-devel@gnu.org; Wed, 23 Mar 2005 04:17:59 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DE1zh-0004DJ-Nz for guile-devel@gnu.org; Wed, 23 Mar 2005 04:17:48 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DE1zg-0004CW-Vl for guile-devel@gnu.org; Wed, 23 Mar 2005 04:17:41 -0500 Original-Received: from [64.233.170.206] (helo=rproxy.gmail.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DE1h0-0006ny-BJ for guile-devel@gnu.org; Wed, 23 Mar 2005 03:58:22 -0500 Original-Received: by rproxy.gmail.com with SMTP id y7so124115rne for ; Wed, 23 Mar 2005 00:58:21 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=iX2rda/xDTc1PC+Fap1sCcdq8wvw6rSTW9j2uvM6TiSqTGlVOENyLVxEP/R4bSUBQdF3D2zjQW1kFHArDiWvyiBwM5+c2UEjgj5o4jR80Z/7YxPQ5t4+w8n69LyZeBcia4Vub78PGIxjcfedZkxTvjZARXvofXSDfftoeoCGiok= Original-Received: by 10.38.181.38 with SMTP id d38mr392239rnf; Wed, 23 Mar 2005 00:58:21 -0800 (PST) Original-Received: by 10.38.104.39 with HTTP; Wed, 23 Mar 2005 00:58:21 -0800 (PST) Original-To: Neil Jerram In-Reply-To: <424125C0.7000407@ossau.uklinux.net> X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org X-MailScanner-To: guile-devel@m.gmane.org Xref: news.gmane.org gmane.lisp.guile.devel:4863 X-Report-Spam: http://spam.gmane.org/gmane.lisp.guile.devel:4863 On Wed, 23 Mar 2005 08:16:00 +0000, Neil Jerram wrote: > OK, to get the ball rolling and fill in my understanding: > scm_make_memoized() in debug.c has: > > SCM_CRITICAL_SECTION_START; > SCM_NEWSMOB (z, SCM_UNPACK (exp), SCM_UNPACK (env)); > SCM_NEWSMOB (ans, scm_tc16_memoized, SCM_UNPACK (z)); > SCM_CRITICAL_SECTION_END; > > So: > > - why do we need a critical section here? We don't. The above code is the result of multiple applications of query-replace during several years of GUile development. All four lines should be replaced by a call to SCM_RETURN_NEWSMOB. M _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel