unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Mikael Djurfeldt <mdjurfeldt@gmail.com>
Cc: guile-devel <guile-devel@gnu.org>
Subject: Re: Critical section review
Date: Wed, 23 Mar 2005 09:58:21 +0100	[thread overview]
Message-ID: <66e540fe050323005822a5d217@mail.gmail.com> (raw)
In-Reply-To: <424125C0.7000407@ossau.uklinux.net>

On Wed, 23 Mar 2005 08:16:00 +0000, Neil Jerram <neil@ossau.uklinux.net> wrote:
> OK, to get the ball rolling and fill in my understanding:
> scm_make_memoized() in debug.c has:
> 
>    SCM_CRITICAL_SECTION_START;
>    SCM_NEWSMOB (z, SCM_UNPACK (exp), SCM_UNPACK (env));
>    SCM_NEWSMOB (ans, scm_tc16_memoized, SCM_UNPACK (z));
>    SCM_CRITICAL_SECTION_END;
> 
> So:
> 
> - why do we need a critical section here?

We don't.

The above code is the result of multiple applications of query-replace
during several years of GUile development. All four lines should be
replaced by a call to SCM_RETURN_NEWSMOB.

M


_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel


  reply	other threads:[~2005-03-23  8:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-23  8:16 Critical section review Neil Jerram
2005-03-23  8:58 ` Mikael Djurfeldt [this message]
2005-03-23  9:02 ` Mikael Djurfeldt
2005-03-23 20:19   ` Neil Jerram
2005-03-23 20:35     ` Mikael Djurfeldt
2005-03-23 21:34     ` Marius Vollmer
2005-03-24  7:30       ` Neil Jerram
2005-03-30 18:46         ` Neil Jerram

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66e540fe050323005822a5d217@mail.gmail.com \
    --to=mdjurfeldt@gmail.com \
    --cc=djurfeldt@nada.kth.se \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).