From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matt Wette Newsgroups: gmane.lisp.guile.devel Subject: Re: patch for mmap and friends Date: Sat, 14 Jan 2023 08:31:00 -0800 Message-ID: <5fda49f2-6e23-9a53-85d2-c1cc38cf0cce@gmail.com> References: <1ee846ab-e9ce-d616-94dd-0056e4b840f9@gmail.com> <445d3567-9bbf-487b-f338-8a16903e9e62@telenet.be> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2918"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Sat Jan 14 17:31:24 2023 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pGjRE-0000bg-HZ for guile-devel@m.gmane-mx.org; Sat, 14 Jan 2023 17:31:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pGjQy-0005qz-Fu; Sat, 14 Jan 2023 11:31:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGjQx-0005pn-1F for guile-devel@gnu.org; Sat, 14 Jan 2023 11:31:07 -0500 Original-Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pGjQv-0000Qi-8D for guile-devel@gnu.org; Sat, 14 Jan 2023 11:31:06 -0500 Original-Received: by mail-pl1-x62d.google.com with SMTP id jn22so26335015plb.13 for ; Sat, 14 Jan 2023 08:31:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9sRvtvtTNTUKWcIyaUxA8TceLDTqrC50+QHJ9BHGL2Q=; b=a5XcZRoOWEnib9WptDig0KmxrtnMG2+GP9x2fou8+MaxjfiMmVpjlZuobVGlpqLf+y fe+/E+EMlYCFkAzJlTupfduQLjPQuYQJYM9qrasYXLfVLo40g0HQIDiz2Owjjp3G/fAF A28xvxQ4XB76Q8Xe1/oAuSnxxGdWQJrHwCUMi2s73QP6ZQZQblsGmywEKuhlB6AfYZJc l97jPDFlPoFvrRyq8IJBo6/BQFaLzXxnaHffu/1KKF/LNCeBczFl1BBF3KLi9LpR42TV +3ZWRrf3aup7uhNjAG3cUQkh0jbjH825BrRvIXiUEhYVLLzTl/e9tSLqEIdriJX9Mm5+ ECkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9sRvtvtTNTUKWcIyaUxA8TceLDTqrC50+QHJ9BHGL2Q=; b=M8wfyXKZ88qvpPbOGhZwGhQop14RdPMZeyWRdeQIbFOeBSgfLQxJHg3q5qqGwCi4Ao RPCkBmsP3lGmsMgNeOugFkM/ro5YAGvCEcc5Wl+wSlYGbjOFDFA2fvzVUw0ZpP2GVEIr L/+nMTJbIE+RZyZkwkKuE86zJgloVGi0HVp/+YMeXwGIt2GOqBOlzBz914umwBSe/19R 1puwzYho+icvQB5omELueWw4EsMg+8Nc4iK5GjmCP+4lJRgMWMP77FdlgbFPSIZXmytw /4fGuoJfUnN+blcjlhLUwY1UyBjMwIkhltd8uOIShtb/3reRVeQcAzlislk0GWzaBuIi aHbA== X-Gm-Message-State: AFqh2koFzs0DO9Xt4GYBQVoeeaDIEMdDB/9l8MIqBE75Fbwf1cEtwjtT gdAb+/TKeB4cGxwS8I+foLaT75YY4dk= X-Google-Smtp-Source: AMrXdXtSmzP6LpxmTJYgE/Jhcy/8JMo2t5FlGI7dNS1lU+9SMyP34mo4jUR/XDprlHToLpi+iPbSFQ== X-Received: by 2002:a17:90a:55c1:b0:226:e640:229f with SMTP id o1-20020a17090a55c100b00226e640229fmr30348805pjm.28.1673713862148; Sat, 14 Jan 2023 08:31:02 -0800 (PST) Original-Received: from [192.168.2.157] (64-52-138-37.championbroadband.com. [64.52.138.37]) by smtp.gmail.com with ESMTPSA id mp15-20020a17090b190f00b00228e56d375asm1692168pjb.33.2023.01.14.08.31.01 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Jan 2023 08:31:01 -0800 (PST) Content-Language: en-US In-Reply-To: <445d3567-9bbf-487b-f338-8a16903e9e62@telenet.be> Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=matt.wette@gmail.com; helo=mail-pl1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.devel:21585 Archived-At: On 1/14/23 7:18 AM, Maxime Devos wrote: > \ > Port objects should be accepted too, as previously asked on > . > As implied by later comments, using a raw fd causes problems with > 'move->fdes'.  For the remaining response, I'll assume that the > function accepts ports as well. > > To avoid this problem, you can add > >   scm_remember_upto_here_1 (fd); > > after the SCM_SYSCALL. > \ > IIRC there is a C trick involving fields, arrays and types to check > this at compile-time instead.  Maybe: > > struct whatever { >    /* if availability of zero-length arrays can be assumed */ >    int foo[sizeof(size_t) - sizeof(void*)]; >    /* alternatively, a weaker but portable check */ >    int foo[sizeof(size_t) - sizeof(void*) + 1]; > }; > > Greetings, > Maxime. Thanks for the feedback.   I'm sorry I missed you comments on the previous round. I did respond to the ones I did catch.    I'll work this and resubmit. Matt