From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Maxime Devos Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] web: send capitalized authorization header scheme Date: Fri, 24 Jun 2022 21:51:00 +0200 Message-ID: <5bb20e5a9a409ab3a47033bb4e0d740c90c50951.camel@telenet.be> References: <20220624163453.29859-1-aconchillo@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-BKeBEslhSPV50xS6Qyw7" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="866"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.38.3-1 To: Aleix Conchillo =?ISO-8859-1?Q?Flaqu=E9?= , guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Fri Jun 24 21:51:39 2022 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o4pL9-000AZu-7e for guile-devel@m.gmane-mx.org; Fri, 24 Jun 2022 21:51:39 +0200 Original-Received: from localhost ([::1]:33168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o4pL7-0006go-PI for guile-devel@m.gmane-mx.org; Fri, 24 Jun 2022 15:51:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4pKj-0006eN-N0 for guile-devel@gnu.org; Fri, 24 Jun 2022 15:51:13 -0400 Original-Received: from laurent.telenet-ops.be ([2a02:1800:110:4::f00:19]:49224) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o4pKh-0006wo-5A for guile-devel@gnu.org; Fri, 24 Jun 2022 15:51:13 -0400 Original-Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by laurent.telenet-ops.be with bizsmtp id n7r52700B4UW6Th017r5n3; Fri, 24 Jun 2022 21:51:05 +0200 In-Reply-To: <20220624163453.29859-1-aconchillo@gmail.com> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1656100265; bh=kNBSnBaEvOQ3PhRIM5AJftTscT5IfeMYGLHkxsDRWis=; h=Subject:From:To:Date:In-Reply-To:References; b=KYGMzpx8JbxsEoWomtxI7rRpu2ZO8cO9DKeiH5X8OINrtsMoswhw9Nybh6kMWrswv ATgRMHeMY75glua/IwCLAMZVitMJNeLDMYH7Wb2P6hv7JuGgT++SqBHEem3hljyDHx nRGwvmyAQUJGiymMB4bEHBVIabnpctbxZ722gHJL7JT4s66dDIvp5rZju9ZdGc6a+/ 0akD46YoGthScQGxKygrcb+fUZ4yd9bQqeIFvNrvAJCQe99wZd0t5YDsQjGslzSVT8 eOerEGpiYUJL+I+JdRQ5pREqtHzmbnlu9M9bdr8XvZgplW/sfIO8S0tQ+xZQsp14Oh feTgXgGFa8uuw== Received-SPF: pass client-ip=2a02:1800:110:4::f00:19; envelope-from=maximedevos@telenet.be; helo=laurent.telenet-ops.be X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:21241 Archived-At: --=-BKeBEslhSPV50xS6Qyw7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Aleix Conchillo Flaqu=C3=A9 schreef op vr 24-06-2022 om 09:34 [-0700]: > * module/web/http.scm (write-credentials): capitalize authorization > header scheme. The standard allows the scheme to be case-insensitive, > however most libraries out there expect the scheme to be capitalized, > which is what it is actually used in RFC > docs (e.g. https://datatracker.ietf.org/doc/html/rfc7617#section-2). Some > libraries even reject lowercase scheme making Guile incompatible. > --- Patch LGTM (untested, though probably good!), though I want to remind you I'm not a maintainer, I just sometimes review things on guile- devel@, so I can't commit it to savannah. Greetings, Maxime. --=-BKeBEslhSPV50xS6Qyw7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYrYVpBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7jEQAQCgffsPyE7SfSauzykbFFTCqv91 J2UYG2tJOlMBk6WwZwD/bTpPiG5e+LpV62lrxokkDixznbjqB08SYtFnMam77AU= =2Gu+ -----END PGP SIGNATURE----- --=-BKeBEslhSPV50xS6Qyw7--