socket.c

socket.c

[Michael Tuexen]

Dear all,

I would like to extend socket.c such that guile supports also SCTP.
If I submit patches against the 1.6.4 version is it possible that
the changes are included in the 1.6.5 release? Or should I submit
patches against the CVS version? Is it still possible to include
the changes into 1.6.5?

Best regards
Michael



_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel

Re: socket.c

[Rob Browning]

Michael Tuexen <Michael.Tuexen@lurchi.franken.de> writes:

> I would like to extend socket.c such that guile supports also SCTP.
> If I submit patches against the 1.6.4 version is it possible that
> the changes are included in the 1.6.5 release? Or should I submit
> patches against the CVS version? Is it still possible to include the
> changes into 1.6.5?

It would depend on the nature of the changes.  For example, I'm about
to add srfi-31 to 1.6 and 1.7, but that will only involve the addition
of a new file, a new test, and some documentation, and nothing should
be affected unless you (use-modules (srfi srfi-31)).

It would defintely be a judgement call.  If the changes can be done in
such a way that it's obvious that they won't break existing build or
runtime behaviors, then that'd be fine, but it's worth mentioning that
we're very likely to err on the side of being conservative with
changes to 1.6.

Hope this helps.
-- 
Rob Browning
rlb @defaultvalue.org and @debian.org; previously @cs.utexas.edu
GPG starting 2002-11-03 = 14DD 432F AE39 534D B592  F9A0 25C8 D377 8C7E 73A4


_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel

Re: socket.c

[Michael Tuexen]

Rob,

thank you very much for the answer. The changes are
- adding some constants
- adding some additional system calls

So it should be clear what the are doing and should not
affect systems not supporting SCTP.

So should I code against the 1.6.4 socket.c file or the
one in the CVS? Do I have better chances to get the stuff
into 1.6.5 when coding against the 1.6.4 version?

Best regards
Michael

On 1. Feb 2004, at 22:34 Uhr, Rob Browning wrote:

> Michael Tuexen <Michael.Tuexen@lurchi.franken.de> writes:
>
>> I would like to extend socket.c such that guile supports also SCTP.
>> If I submit patches against the 1.6.4 version is it possible that
>> the changes are included in the 1.6.5 release? Or should I submit
>> patches against the CVS version? Is it still possible to include the
>> changes into 1.6.5?
>
> It would depend on the nature of the changes.  For example, I'm about
> to add srfi-31 to 1.6 and 1.7, but that will only involve the addition
> of a new file, a new test, and some documentation, and nothing should
> be affected unless you (use-modules (srfi srfi-31)).
>
> It would defintely be a judgement call.  If the changes can be done in
> such a way that it's obvious that they won't break existing build or
> runtime behaviors, then that'd be fine, but it's worth mentioning that
> we're very likely to err on the side of being conservative with
> changes to 1.6.
>
> Hope this helps.
> -- 
> Rob Browning
> rlb @defaultvalue.org and @debian.org; previously @cs.utexas.edu
> GPG starting 2002-11-03 = 14DD 432F AE39 534D B592  F9A0 25C8 D377 
> 8C7E 73A4
>



_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel

Re: socket.c

[Rob Browning]

Michael Tuexen <Michael.Tuexen@lurchi.franken.de> writes:

> So should I code against the 1.6.4 socket.c file or the
> one in the CVS? Do I have better chances to get the stuff
> into 1.6.5 when coding against the 1.6.4 version?

Definitely code against the 1.6 branch.  From CVS, update or checkout
with "-r branch_release-1-6", though if you're concerned about
acceptance, you might want to wait a day or so to see if there are any
other strong objections.

-- 
Rob Browning
rlb @defaultvalue.org and @debian.org; previously @cs.utexas.edu
GPG starting 2002-11-03 = 14DD 432F AE39 534D B592  F9A0 25C8 D377 8C7E 73A4


_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel

Re: socket.c

[Michael Tuexen]

Hi Rob,

thank you very much for the guidance. I will submit the code
to the list.

Best regards
Michael

On 1. Feb 2004, at 23:19 Uhr, Rob Browning wrote:

> Michael Tuexen <Michael.Tuexen@lurchi.franken.de> writes:
>
>> So should I code against the 1.6.4 socket.c file or the
>> one in the CVS? Do I have better chances to get the stuff
>> into 1.6.5 when coding against the 1.6.4 version?
>
> Definitely code against the 1.6 branch.  From CVS, update or checkout
> with "-r branch_release-1-6", though if you're concerned about
> acceptance, you might want to wait a day or so to see if there are any
> other strong objections.
>
> -- 
> Rob Browning
> rlb @defaultvalue.org and @debian.org; previously @cs.utexas.edu
> GPG starting 2002-11-03 = 14DD 432F AE39 534D B592  F9A0 25C8 D377 
> 8C7E 73A4
>



_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel