From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Maxime Devos Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Added srfi-214: flexvectors Date: Wed, 19 Jan 2022 10:00:01 +0100 Message-ID: <53571f80fa796b002f696c68ba2151d97bb6edad.camel@telenet.be> References: <8735lk1mim.fsf@vijaymarupudi.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-5R9E/lTct7h5eofhSLyd" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2947"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.38.3-1 To: Vijay Marupudi , guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Wed Jan 19 10:36:27 2022 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nA7OE-0000dI-6B for guile-devel@m.gmane-mx.org; Wed, 19 Jan 2022 10:36:26 +0100 Original-Received: from localhost ([::1]:48350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nA7OC-0003wq-Ph for guile-devel@m.gmane-mx.org; Wed, 19 Jan 2022 04:36:25 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nA6p9-0005md-DY for guile-devel@gnu.org; Wed, 19 Jan 2022 04:00:11 -0500 Original-Received: from [2a02:1800:120:4::f00:15] (port=45062 helo=andre.telenet-ops.be) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nA6p3-00051s-VI for guile-devel@gnu.org; Wed, 19 Jan 2022 04:00:11 -0500 Original-Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by andre.telenet-ops.be with bizsmtp id kZ022600C4UW6Th01Z028D; Wed, 19 Jan 2022 10:00:02 +0100 In-Reply-To: <8735lk1mim.fsf@vijaymarupudi.com> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1642582802; bh=9eKa1lpWMA+2/NdaQA8x4ltKnwH4j3uiIyJQoSPg8Fc=; h=Subject:From:To:Date:In-Reply-To:References; b=L97cqnWCwEBnRivGYjvlqC5dbnHdBNoAWzRnwB//mxACRq8UqxzAbfNM06fbV7qTt qzFwt1smKtLAtmnA3xKNcVsPXZ3QNGwheahd8F2RobUc2XXU5+KY6ia2yLIHnOH6lP VUXCLlFWoBZlOclw2dd0o5AOATV/nyZOIKN6QOoKM9PDUsadm6Mk8QjA1HKA6FY9DF e8zaxVlN8Y46Z6uLKJ7/+vzikOdOsFwaECWUvwuOm9BCNVqZPcXhwKzlu4jJSwO7Jx VuKzDaM6Hgbdmc2UPR20PuLtCK+bemjtIqXMm+San/BJzM87d+L7sIhB055XnIBsGd wzA6h5eRXVmoQ== X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a02:1800:120:4::f00:15 (failed) Received-SPF: pass client-ip=2a02:1800:120:4::f00:15; envelope-from=maximedevos@telenet.be; helo=andre.telenet-ops.be X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:21034 Archived-At: --=-5R9E/lTct7h5eofhSLyd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Vijay Marupudi schreef op di 18-01-2022 om 21:34 [-0500]: > Hello, >=20 > I have attached to this email a patch to add support for srfi-214, > flexvectors. >=20 > I have made as few changes to the code from the sample implementation. >=20 > If this is accepted, I can work on adding to the documentation. >=20 > I have been using this for a while, and it has worked wonderfully. How about including the tests (https://github.com/scheme-requests-for-implementation/srfi-214/blob/master= /implementation/tests.scm) as well? Guile doesn't use SRFI-64 in its own tests though, so some changes may be necessary. I noticed you started the patch with: +;;; Copyright (C) 2022 Free Software Foundation, Inc. +;;; [LGPL blurb] however, the README says =E2=80=98by Adam Nelson=E2=80=99. Did you reach s= ome kind of agreement with Adam Nelson about copyright assignment? And since SRFIs are licensed under Expat (not 100% sure), wouldn't this need to be the Expat license text? Even if the Expat license allows this (I don't know), then I would still recommend to keep the license the same, such that fixes can easily be interchanged between Scheme implementations (e.g. there have been some fixes to SRFI-64 a while ago). Greetings, Maxime. --=-5R9E/lTct7h5eofhSLyd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYefTERccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7lKtAQDH9Ky+KwfexrOdbXK/fYdNkbtU 0mMMyEpZSL68dSgM5AD9Ep95nQWE5DhMaa1g9BNfwA6BYjLsIVMLmH/axRy9PgM= =Mt94 -----END PGP SIGNATURE----- --=-5R9E/lTct7h5eofhSLyd--