From: Maxime Devos <maximedevos@telenet.be>
To: Vijay Marupudi <vijay@vijaymarupudi.com>, guile-devel@gnu.org
Subject: Re: [PATCH] Added srfi-214: flexvectors
Date: Wed, 19 Jan 2022 10:00:01 +0100 [thread overview]
Message-ID: <53571f80fa796b002f696c68ba2151d97bb6edad.camel@telenet.be> (raw)
In-Reply-To: <8735lk1mim.fsf@vijaymarupudi.com>
[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]
Vijay Marupudi schreef op di 18-01-2022 om 21:34 [-0500]:
> Hello,
>
> I have attached to this email a patch to add support for srfi-214,
> flexvectors.
>
> I have made as few changes to the code from the sample implementation.
>
> If this is accepted, I can work on adding to the documentation.
>
> I have been using this for a while, and it has worked wonderfully.
How about including the tests
(https://github.com/scheme-requests-for-implementation/srfi-214/blob/master/implementation/tests.scm)
as well?
Guile doesn't use SRFI-64 in its own tests though, so some changes may
be necessary.
I noticed you started the patch with:
+;;; Copyright (C) 2022 Free Software Foundation, Inc.
+;;; [LGPL blurb]
however, the README says ‘by Adam Nelson’. Did you reach some kind of
agreement with Adam Nelson about copyright assignment? And since SRFIs
are licensed under Expat (not 100% sure), wouldn't this need to be the
Expat license text?
Even if the Expat license allows this (I don't know), then I would
still recommend to keep the license the same, such that fixes can
easily be interchanged between Scheme implementations (e.g. there have
been some fixes to SRFI-64 a while ago).
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-01-19 9:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 2:34 [PATCH] Added srfi-214: flexvectors Vijay Marupudi
2022-01-19 9:00 ` Maxime Devos [this message]
2022-01-19 13:55 ` Vijay Marupudi
[not found] ` <87wnivzvd4.fsf@vijaymarupudi.com>
2022-01-19 15:04 ` Maxime Devos
2022-01-19 15:44 ` Vijay Marupudi
2022-01-19 16:04 ` Maxime Devos
2022-01-20 15:34 ` Vijay Marupudi
2022-01-20 16:53 ` Maxime Devos
2022-01-20 17:57 ` Vijay Marupudi
2022-01-20 18:15 ` Maxime Devos
2022-01-20 20:38 ` Vijay Marupudi
2022-10-07 19:58 ` Vijay Marupudi
2022-10-12 12:22 ` Ludovic Courtès
2022-11-13 20:27 ` Vijay Marupudi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53571f80fa796b002f696c68ba2151d97bb6edad.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=guile-devel@gnu.org \
--cc=vijay@vijaymarupudi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).