From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Thompson Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Add procedures to convert alists into hash tables Date: Sun, 17 Nov 2013 20:50:35 -0500 Message-ID: <5289726B.6030302@worcester.edu> References: <5263E55A.6040307@worcester.edu> <87txg0p805.fsf@gnu.org> <87iow6pqox.fsf@netris.org> <87mwlhlmgr.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------020204060706000805090901" X-Trace: ger.gmane.org 1384739441 22083 80.91.229.3 (18 Nov 2013 01:50:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 18 Nov 2013 01:50:41 +0000 (UTC) Cc: Mark H Weaver , guile-devel To: =?UTF-8?B?THVkb3ZpYyBDb3VydMOocw==?= Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Nov 18 02:50:45 2013 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ViDzA-0001jw-Cn for guile-devel@m.gmane.org; Mon, 18 Nov 2013 02:50:44 +0100 Original-Received: from localhost ([::1]:40900 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViDz9-0004jL-TO for guile-devel@m.gmane.org; Sun, 17 Nov 2013 20:50:43 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViDz2-0004jG-Nw for guile-devel@gnu.org; Sun, 17 Nov 2013 20:50:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ViDyw-0005qw-Tg for guile-devel@gnu.org; Sun, 17 Nov 2013 20:50:36 -0500 Original-Received: from na3sys009aog116.obsmtp.com ([74.125.149.240]:59023) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViDyw-0005qm-J0 for guile-devel@gnu.org; Sun, 17 Nov 2013 20:50:30 -0500 Original-Received: from mail-qe0-f53.google.com ([209.85.128.53]) (using TLSv1) by na3sys009aob116.postini.com ([74.125.148.12]) with SMTP ID DSNKUolyZE31Sa7LsLAV0P5zaX01GpIsgtyX@postini.com; Sun, 17 Nov 2013 17:50:30 PST Original-Received: by mail-qe0-f53.google.com with SMTP id cy11so3707457qeb.12 for ; Sun, 17 Nov 2013 17:50:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type; bh=BKh8Akgae+EeAIb0EJZuimIkKlzRUhlr6Z0lL/Z30pE=; b=GPqIqHeBEQq/gOXyg84N3m26DHGgRJtJG5sNKn5Ezg9RyJdFcLcdS6v5yMQXL7rum2 IzEPpt2/j2nShA36livB4UfdDZJzuLgZddm+XTLN9fbLanRcKbiGFsi/BJNc4oP72qHC 2iBSj+j6mb8dzEhQZ59B3otJudlm66y/1HFfJSHNOuhQKscgKVDTwBkP3p09tyLC0Yct ROm3NPPukBPYJwcq4a3NMnlzbDxMzqCmjnVWMqmerAfweXOZ90nq0bqK/mZEj9ZIPF0r bb8weaEMf0H/CtNi5shff4oyY6a9JYngGHJfkYZplIgTAhNCGMecPUK6UzTJpPch00et 0E/A== X-Gm-Message-State: ALoCoQlve5kyMDGob8oQwmzV8Pt3EmbcCj80ctIy4pdtTkRelPYV5Uq96O3K9xk1yz7yyGD6XaweTRs3jI/v1ACzK+L2dNKzO03B+3RA9y4MBhSLfYM2NM10Okc2M49w+wKGffUAa+9i68p2EZfJPXFW1iiKLhVhPw== X-Received: by 10.49.63.164 with SMTP id h4mr15801787qes.62.1384739427803; Sun, 17 Nov 2013 17:50:27 -0800 (PST) X-Received: by 10.49.63.164 with SMTP id h4mr15801780qes.62.1384739427676; Sun, 17 Nov 2013 17:50:27 -0800 (PST) Original-Received: from [192.168.1.157] (209-6-40-86.c3-0.smr-ubr1.sbo-smr.ma.cable.rcn.com. [209.6.40.86]) by mx.google.com with ESMTPSA id b9sm34812422qas.7.2013.11.17.17.50.25 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 17 Nov 2013 17:50:26 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 In-Reply-To: <87mwlhlmgr.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-Received-From: 74.125.149.240 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:16745 Archived-At: This is a multi-part message in MIME format. --------------020204060706000805090901 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 11/06/2013 07:54 AM, Ludovic Courtès wrote: > Mark H Weaver skribis: > >> "Thompson, David" writes: >> >>> On Tue, Oct 29, 2013 at 8:38 AM, Ludovic Courtès wrote: >>>> I think it would make sense to implement them in Scheme, say in >>>> ice-9/hash-table.scm, which could be either a separate module or a file >>>> included from boot-9.scm. >>>> >>>> WDYT? >>> >>> Does anyone else feel that this is a better approach? >> >> FWIW, I think Ludovic is right. There's no compelling reason to write >> these procedures in C, and it would be good to reduce the amount of C >> code for several reasons. However, unlike ttn, I think it would be good >> to have these procedures in core Guile. > > Agreed. > > David: would you be willing to do that? Apologies for my late comment, > and for the extra work involved. Your contributions are appreciated! > > Thanks, > Ludo’. > Finally got around to updating this patch. I opted for adding a standalone module named (ice-9 hash-table) rather than including it from boot-9. How did I do? - Dave --------------020204060706000805090901 Content-Type: text/x-patch; name="0001-Add-procedures-to-convert-alists-into-hash-tables.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-Add-procedures-to-convert-alists-into-hash-tables.patch" >From 30b122a2638689e919f8b6722905ed5fa51e2138 Mon Sep 17 00:00:00 2001 From: David Thompson Date: Sat, 19 Oct 2013 22:43:37 -0400 Subject: [PATCH] Add procedures to convert alists into hash tables. * module/ice-9/hash-table.scm: New module. * test-suite/tests/hash.test ("alist conversion"): Add tests. * doc/ref/api-compound.texi (Hash Table Reference): Add docs. --- doc/ref/api-compound.texi | 21 +++++++++++++++++++++ module/ice-9/hash-table.scm | 45 +++++++++++++++++++++++++++++++++++++++++++++ test-suite/tests/hash.test | 38 +++++++++++++++++++++++++++++++++++++- 3 files changed, 103 insertions(+), 1 deletion(-) create mode 100644 module/ice-9/hash-table.scm diff --git a/doc/ref/api-compound.texi b/doc/ref/api-compound.texi index 94e0145..9e5e649 100644 --- a/doc/ref/api-compound.texi +++ b/doc/ref/api-compound.texi @@ -3829,6 +3829,27 @@ then it can use @var{size} to avoid rehashing when initial entries are added. @end deffn +@deffn {Scheme Procedure} alist->hash-table alist +@deffnx {Scheme Procedure} alist->hashq-table alist +@deffnx {Scheme Procedure} alist->hashv-table alist +@deffnx {Scheme Procedure} alist->hashx-table hash assoc alist +Convert @var{alist} into a hash table. When keys are repeated in +@var{alist}, the leftmost association takes precedence. + +@example +(use-modules (ice-9 hash-table)) +(alist->hash-table '((foo . 1) (bar . 2))) +@end example + +When converting to an extended hash table, custom @var{hash} and +@var{assoc} procedures must be provided. + +@example +(alist->hash-table hash assoc '((foo . 1) (bar . 2))) +@end example + +@end deffn + @deffn {Scheme Procedure} hash-table? obj @deffnx {C Function} scm_hash_table_p (obj) Return @code{#t} if @var{obj} is a abstract hash table object. diff --git a/module/ice-9/hash-table.scm b/module/ice-9/hash-table.scm new file mode 100644 index 0000000..6b0fa04 --- /dev/null +++ b/module/ice-9/hash-table.scm @@ -0,0 +1,45 @@ +;;;; hash-table.scm --- Additional hash table procedures +;;;; Copyright (C) 2013 Free Software Foundation, Inc. +;;;; +;;;; This library is free software; you can redistribute it and/or +;;;; modify it under the terms of the GNU Lesser General Public +;;;; License as published by the Free Software Foundation; either +;;;; version 3 of the License, or (at your option) any later version. +;;;; +;;;; This library is distributed in the hope that it will be useful, +;;;; but WITHOUT ANY WARRANTY; without even the implied warranty of +;;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +;;;; Lesser General Public License for more details. +;;;; +;;;; You should have received a copy of the GNU Lesser General Public +;;;; License along with this library; if not, write to the Free Software +;;;; Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA +;;;; + +(define-module (ice-9 hash-table) + #:export (alist->hash-table + alist->hashq-table + alist->hashv-table + alist->hashx-table)) + +(define-syntax-rule (define-alist-converter name hash-set-proc) + (define (name alist) + "Convert @var{alist} into a hash table." + (let ((table (make-hash-table))) + (for-each (lambda (pair) + (hash-set-proc table (car pair) (cdr pair))) + (reverse alist)) + table))) + +(define-alist-converter alist->hash-table hash-set!) +(define-alist-converter alist->hashq-table hashq-set!) +(define-alist-converter alist->hashv-table hashv-set!) + +(define (alist->hashx-table hash assoc alist) + "Convert @var{alist} into a hash table with custom @var{hash} and +@var{assoc} procedures." + (let ((table (make-hash-table))) + (for-each (lambda (pair) + (hashx-set! hash assoc table (car pair) (cdr pair))) + (reverse alist)) + table)) diff --git a/test-suite/tests/hash.test b/test-suite/tests/hash.test index 3bd4004..ad247f5 100644 --- a/test-suite/tests/hash.test +++ b/test-suite/tests/hash.test @@ -18,7 +18,8 @@ (define-module (test-suite test-numbers) #:use-module (test-suite lib) - #:use-module (ice-9 documentation)) + #:use-module (ice-9 documentation) + #:use-module (ice-9 hash-table)) ;;; ;;; hash @@ -81,6 +82,41 @@ (write (make-hash-table 100))))))) ;;; +;;; alist->hash-table +;;; + +(with-test-prefix + "alist conversion" + + (pass-if "alist->hash-table" + (let ((table (alist->hash-table '(("foo" . 1) + ("bar" . 2) + ("foo" . 3))))) + (and (= (hash-ref table "foo") 1) + (= (hash-ref table "bar") 2)))) + + (pass-if "alist->hashq-table" + (let ((table (alist->hashq-table '((foo . 1) + (bar . 2) + (foo . 3))))) + (and (= (hashq-ref table 'foo) 1) + (= (hashq-ref table 'bar) 2)))) + + (pass-if "alist->hashv-table" + (let ((table (alist->hashv-table '((1 . 1) + (2 . 2) + (1 . 3))))) + (and (= (hashv-ref table 1) 1) + (= (hashv-ref table 2) 2)))) + + (pass-if "alist->hashx-table" + (let ((table (alist->hashx-table hash assoc '((foo . 1) + (bar . 2) + (foo . 3))))) + (and (= (hashx-ref hash assoc table 'foo) 1) + (= (hashx-ref hash assoc table 'bar) 2))))) + +;;; ;;; usual set and reference ;;; -- 1.8.4.2 --------------020204060706000805090901--