From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bruce Korb Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] do not augment environment Date: Mon, 01 Oct 2012 07:24:00 -0700 Message-ID: <5069A780.1040700@gmail.com> References: <505CF9FC.9060007@gmail.com> <5069022C.9040600@netris.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1349101462 26164 80.91.229.3 (1 Oct 2012 14:24:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 1 Oct 2012 14:24:22 +0000 (UTC) Cc: Guile Development To: Mark H Weaver Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Oct 01 16:24:26 2012 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TIgv0-0007EP-Qi for guile-devel@m.gmane.org; Mon, 01 Oct 2012 16:24:22 +0200 Original-Received: from localhost ([::1]:59848 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIguv-00048Y-9g for guile-devel@m.gmane.org; Mon, 01 Oct 2012 10:24:17 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46495) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIguo-000489-9T for guile-devel@gnu.org; Mon, 01 Oct 2012 10:24:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TIgui-0007gy-8v for guile-devel@gnu.org; Mon, 01 Oct 2012 10:24:10 -0400 Original-Received: from mail-pa0-f41.google.com ([209.85.220.41]:61317) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIgui-0007go-2h for guile-devel@gnu.org; Mon, 01 Oct 2012 10:24:04 -0400 Original-Received: by padfa10 with SMTP id fa10so4607466pad.0 for ; Mon, 01 Oct 2012 07:24:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=sE8G3a7HhO70IqbPQyFSRK9E9Y1afDjWb1dRdbVuz3c=; b=jHzsvdKyGICKV+M9T0hC5JataxRuENUJRYnyhzTAxJG+91clm48yimS7NnGhb5Q0EW B2rRemr7BnvyUZ1rD/IN+NwISgwn+gm31oC/pSxpXsu05dfgcljV/8tpc/ADsH8d8HAd +TyJWR18O/vduea7roFly4nJq32+KpyuJhjbM2aDJz5KSvOAazACD2WL+MWHSJa7+vv5 UVukR6HTQ71+G5gaO3Muw0gnRKHSAqncElwkL6BScGg/vWbOAObWOrwWDfdswliCz9+2 oOOstoA7hgUII57RrQ1tqU2JLt6VaBhCHUIasjkdyXJhWtIBvQXUznTP3aSLukxC/TYw /BQw== Original-Received: by 10.68.197.70 with SMTP id is6mr41140447pbc.64.1349101443388; Mon, 01 Oct 2012 07:24:03 -0700 (PDT) Original-Received: from [192.168.10.2] (adsl-76-254-31-152.dsl.pltn13.sbcglobal.net. [76.254.31.152]) by mx.google.com with ESMTPS id m5sm10466283pax.10.2012.10.01.07.24.01 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 01 Oct 2012 07:24:02 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120825 Thunderbird/15.0 In-Reply-To: <5069022C.9040600@netris.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.220.41 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:14921 Archived-At: Hi Mark, On 09/30/12 19:38, Mark H Weaver wrote: > Thanks for the patch, but I think it needs more work before it can be > committed. See below for my comments. You're welcome! Just FYI, I've got no ego wrapped up in being the one to type in characters, so fixing things up for preferred style or oversights would be no concern to me at all. > * You assume that the directory separator is '/'. Either that, or a wrapper environment fixes it up. If there is a conventional way of dealing with Microsoft-did-it-their-way issues, I don't know what it is. I'm not overly familiar with Guile code. > * You should not do the extra search if 'fname' is an absolute > pathname, and I'm not sure whether it should be done for relative > pathnames containing directory separators. Does anyone else have > thoughts on that? It is already an "unusual case" path. The extra check would save a few cpu cycles when the unusual case was going to fail. This saves one or two cycles in the marginally more common case of the unusual case succeeding. > * As a stylistic issue, I don't like your trick of breaking out of the > do-while. I'd prefer something closer to this (but with the above > problems addressed): I consider it a developed style. :) The deeper the logic nesting, the more complex the code, to my eyes anyway. In this particular case, we're talking about "break" in the third level instead of two statements. I definitely think the two statements make for microscopically more complex code. That is likely much outweighed by familiarity with the technique. All that notwithstanding, it's your code and what I provided I considered mostly a guideline for what needs to happen to eliminate the LD_LIBRARY_PATH fiddling. Just let me know how to plug in the Microsoft directory separator when needed and I'll resubmit the patch. NOTE: I'll be out of town the 10th through 20th. Thanks - Bruce