From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark H Weaver Newsgroups: gmane.lisp.guile.devel Subject: Re: guile --listen fix Date: Mon, 01 Oct 2012 01:48:58 -0400 Message-ID: <50692ECA.7030505@netris.org> References: <87mx0mhs6p.fsf@googlemail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1349070557 25225 80.91.229.3 (1 Oct 2012 05:49:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 1 Oct 2012 05:49:17 +0000 (UTC) Cc: guile-devel@gnu.org To: Ian Price Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Oct 01 07:49:21 2012 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TIYsX-00013r-N9 for guile-devel@m.gmane.org; Mon, 01 Oct 2012 07:49:17 +0200 Original-Received: from localhost ([::1]:57656 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIYsS-0001gN-8O for guile-devel@m.gmane.org; Mon, 01 Oct 2012 01:49:12 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37881) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIYsP-0001fw-F9 for guile-devel@gnu.org; Mon, 01 Oct 2012 01:49:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TIYsO-0003EY-Cv for guile-devel@gnu.org; Mon, 01 Oct 2012 01:49:09 -0400 Original-Received: from world.peace.net ([96.39.62.75]:55598) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIYsO-0003EL-8Y for guile-devel@gnu.org; Mon, 01 Oct 2012 01:49:08 -0400 Original-Received: from 209-6-91-212.c3-0.smr-ubr1.sbo-smr.ma.cable.rcn.com ([209.6.91.212] helo=[192.168.1.176]) by world.peace.net with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1TIYsH-0002c1-Bc; Mon, 01 Oct 2012 01:49:01 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.7) Gecko/20120922 Icedove/10.0.7 In-Reply-To: <87mx0mhs6p.fsf@googlemail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 96.39.62.75 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:14920 Archived-At: Hi Ian, Sorry for sending two emails in quick succession, but I just realized that there is one minor problem with your proposed commit which should ideally be fixed: the commit log message. > * module/ice-9/command-line.scm (compile-shell-switches): @@ no longer > supports arbitrary expressions, only identifiers. The commit log should briefly describe the changes made within the associated patch. The rationale for the changes should be secondary, and arguably do not belong in the commit log at all. In this case, your commit log does not describe your changes at all. It contains only the rationale. The result is quite misleading, because it suggests that your commit changed the way '@@' behaves. It would perhaps have been a suitable commit log for my earlier commit (8210c85), but it is quite inappropriate for your commit. Mark