From: Mark H Weaver <mhw@netris.org>
To: Ian Price <ianprice90@googlemail.com>
Cc: guile-devel@gnu.org
Subject: Re: guile --listen fix
Date: Mon, 01 Oct 2012 01:48:58 -0400 [thread overview]
Message-ID: <50692ECA.7030505@netris.org> (raw)
In-Reply-To: <87mx0mhs6p.fsf@googlemail.com>
Hi Ian,
Sorry for sending two emails in quick succession, but I just realized
that there is one minor problem with your proposed commit which should
ideally be fixed: the commit log message.
> * module/ice-9/command-line.scm (compile-shell-switches): @@ no longer
> supports arbitrary expressions, only identifiers.
The commit log should briefly describe the changes made within the
associated patch. The rationale for the changes should be secondary,
and arguably do not belong in the commit log at all.
In this case, your commit log does not describe your changes at all. It
contains only the rationale.
The result is quite misleading, because it suggests that your commit
changed the way '@@' behaves. It would perhaps have been a suitable
commit log for my earlier commit (8210c85), but it is quite
inappropriate for your commit.
Mark
next prev parent reply other threads:[~2012-10-01 5:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 16:51 guile --listen fix Ian Price
2012-09-19 17:18 ` Mark H Weaver
2012-09-19 19:59 ` Ian Price
2012-10-01 5:31 ` Mark H Weaver
2012-10-01 5:48 ` Mark H Weaver [this message]
2012-10-18 4:14 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50692ECA.7030505@netris.org \
--to=mhw@netris.org \
--cc=guile-devel@gnu.org \
--cc=ianprice90@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).