unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: "Ludovic Courtès" <ludo@gnu.org>, guile-user@gnu.org
Cc: guile-devel@gnu.org
Subject: Re: mmap for guile
Date: Tue, 19 Jul 2022 15:20:56 +0200	[thread overview]
Message-ID: <4c07ec35d773ecb8d4d7ea6687a4c11cd2a221b0.camel@telenet.be> (raw)
In-Reply-To: <87k08tfau0.fsf@gnu.org>

Ludovic Courtès schreef op ma 04-07-2022 om 12:09 [+0200]:
> I don’t think the optimizer makes any such assumption, except for
> literal bytevectors.

It _does_ assume that bytevector lengths don't change:

,use (rnrs bytevectors)
,compile (bytevector-u8-ref some-variable 999)

;;; <unknown-location>: warning: possibly unbound variable `some-variable'
Disassembly of <unnamed function> at #xe8:

   0    (instrument-entry 254)                                at (unknown file):4:9
   2    (assert-nargs-ee/locals 1 3)    ;; 4 slots (0 args)
   3    (call-scm<-thread 3 62)                               at (unknown file):4:28
   5    (static-ref 2 187)              ;; some-variable
   7    (call-scm<-scm-scm 3 3 2 111)   
   9    (scm-ref/immediate 3 3 1)       
  10    (make-immediate 2 3998)         ;; 999                at (unknown file):4:42
  11    (immediate-tag=? 3 7 0)         ;; heap-object?       at (unknown file):4:9
  13    (jne 21)                        ;; -> L2
  14    (heap-tag=? 3 127 77)           ;; bytevector?
  16    (jne 18)                        ;; -> L2
  17    (word-ref/immediate 1 3 1)      
  18    (load-s64 0 0 999)              
  21    (imm-u64<? 1 0)                 
  22    (jnl 10)                        ;; -> L1
  23    (usub/immediate 1 1 0)          
  24    (u64<? 0 1)                     
  25    (jnl 7)                         ;; -> L1
  26    (pointer-ref/immediate 2 3 2)   
  27    (u8-ref 3 2 0)                  
  28    (tag-fixnum 3 3)                
  29    (reset-frame 1)                 ;; 1 slot
  30    (handle-interrupts)             
  31    (return-values)                 
L1:
  32    (throw/value+data 2 188)        ;; #(out-of-range "bytevector-u8-ref" "Argument 2 out of range: ~S")
L2:
  34    (throw/value+data 3 212)        ;; #(wrong-type-arg "bytevector-u8-ref" "Wrong type argument in position 1 (ex…")

As can be seen in the above output, it first determines
the length of the bytevector and then compares it again the index
(for the index check) and then actually reads th byte
so it assumes that the length doesn't change in-between -- it's not an
atomic operation!

Even if it didn't, being able to assume bytevector lengths don't change
is important for optimising code like (begin (bytevector-ref bv 9000) (bytevector-ref 8999) ...)),
to optimise out many range checks, though I don't know if Guile currently
does that.

Greetings,
Maxime.



  parent reply	other threads:[~2022-07-19 13:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-26 15:37 mmap for guile Matt Wette
2022-06-26 16:21 ` Matt Wette
2022-06-26 17:06 ` Olivier Dion via Developers list for Guile, the GNU extensibility library
2022-06-26 18:11 ` Maxime Devos
2022-07-04 10:09   ` Ludovic Courtès
2022-07-04 13:14     ` Greg Troxel
2022-07-04 20:03       ` Ludovic Courtès
2022-07-05 12:49         ` Greg Troxel
2022-07-19 13:20     ` Maxime Devos [this message]
2022-07-21  9:14       ` Ludovic Courtès
2022-07-19 13:30     ` Maxime Devos
2022-07-19 13:34     ` Maxime Devos
2022-06-26 18:21 ` Maxime Devos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c07ec35d773ecb8d4d7ea6687a4c11cd2a221b0.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=guile-devel@gnu.org \
    --cc=guile-user@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).