From: Bruce Korb <bkorb@gnu.org>
To: Andy Wingo <wingo@pobox.com>
Cc: "Ludovic Courtès" <ludo@gnu.org>,
Ludovic@gnu.org, "guile-devel Development" <guile-devel@gnu.org>
Subject: Re: reprise: scm_c_eval_string_from_file_line
Date: Thu, 10 Mar 2011 01:35:56 -0800 [thread overview]
Message-ID: <4D789B7C.4050807@gnu.org> (raw)
In-Reply-To: <m339mw82z0.fsf@unquote.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]
Hi Andy,
On 03/09/11 12:15, Andy Wingo wrote:
>>> So, this should go under:
>>> #if GUILE_VERSION > 200000 // anything after 2.0, e.g. 2.0.1 ??
>>
>> Rather use AC_CHECK_FUNC.
>
> You'd have to check for (ice-9 eval-string) as well, added at the same
> time.
Then scm_call_5 implies (ice-9 eval-string), and vice versa.
AC_CHECK_FUNC is the correct approach for testing platform features
coming from different vendors. It is not the right approach for
dealing with one platform (the Guile library) that has well understood
features and feature (interface) changes. I've actually developed
an entire glue layer. My "ag" interface layers on top of the
gh/scm/whatever and is provided by a header and a little code.
The header is enclosed for your amusement. I don't think 30 feature
tests is appropriate. autoconf takes long enough as it is,
hence my little "libposix" project. To elaborate here a bit, it
basically installs fixed or missing POSIX stuff on a platform.
By testing for the existence and version (note: "VERSION") of that
library, you can safely presume all the POSIX bits are present
and working, and eliminate all the "is this POSIX feature present"
feature tests. The bulk of my build time is autoconf feature testing.
[-- Attachment #2: guile-iface.h --]
[-- Type: text/x-chdr, Size: 7641 bytes --]
#if GUILE_VERSION < 107000
# define AG_SCM_APPLY2(_op, _f, _tst) gh_call2(_op, _f, _tst)
# define AG_SCM_BOOL_P(_b) SCM_BOOLP(_b)
# define AG_SCM_BOOT_GUILE(_ac, _av, _im) \
gh_enter((_ac), (_av), (_im))
# define AG_SCM_CHAR(_c) gh_scm2char(_c)
# define AG_SCM_CHARS(_s) SCM_CHARS(_s)
# define AG_SCM_CHAR_P(_c) SCM_CHARP(_c)
# define AG_SCM_DISPLAY(_s) gh_display(_s)
# define AG_SCM_FALSEP(_r) SCM_FALSEP(_r)
# define AG_SCM_FROM_LONG(_l) gh_long2scm(_l)
# define AG_SCM_INT2SCM(_i) gh_int2scm(_i)
# define AG_SCM_IS_PROC(_p) SCM_NFALSEP( scm_procedure_p(_p))
# define AG_SCM_LIST_P(_l) SCM_NFALSEP( scm_list_p(_l))
# define AG_SCM_LISTOFNULL() scm_listofnull
# define AG_SCM_LONG2SCM(_i) gh_long2scm(_i)
# define AG_SCM_NFALSEP(_r) SCM_NFALSEP(_r)
# define AG_SCM_NULLP(_m) scm_is_null(_m)
# define AG_SCM_NUM_P(_n) SCM_NUMBERP(_n)
# define AG_SCM_PAIR_P(_p) SCM_NFALSEP( scm_pair_p(_p))
# define AG_SCM_STR02SCM(_s) scm_makfrom0str(_s)
# define AG_SCM_STR2SCM(_st,_sz) scm_mem2string(_st,_sz)
# define AG_SCM_STRING_P(_s) SCM_STRINGP(_s)
# define AG_SCM_STRLEN(_s) SCM_STRING_LENGTH(_s)
# define AG_SCM_SYM_P(_s) SCM_SYMBOLP(_s)
# define AG_SCM_TO_INT(_i) gh_scm2int(_i)
# define AG_SCM_TO_LONG(_v) gh_scm2long(_v)
# define AG_SCM_TO_NEWSTR(_s) gh_scm2newstr(_s, NULL)
# define AG_SCM_TO_ULONG(_v) gh_scm2ulong(_v)
# define AG_SCM_VEC_P(_v) SCM_VECTORP(_v)
#elif GUILE_VERSION < 108000
# define AG_SCM_APPLY2(_op, _f, _tst) gh_call2(_op, _f, _tst)
# define AG_SCM_BOOL_P(_b) SCM_BOOLP(_b)
# define AG_SCM_BOOT_GUILE(_ac, _av, _im) \
gh_enter((_ac), (_av), (_im))
# define AG_SCM_CHAR(_c) gh_scm2char(_c)
# define AG_SCM_CHARS(_s) SCM_STRING_CHARS(_s)
# define AG_SCM_CHAR_P(_c) SCM_CHARP(_c)
# define AG_SCM_DISPLAY(_s) gh_display(_s)
# define AG_SCM_FALSEP(_r) scm_is_false(_r)
# define AG_SCM_FROM_LONG(_l) gh_long2scm(_l)
# define AG_SCM_INT2SCM(_i) gh_int2scm(_i)
# define AG_SCM_IS_PROC(_p) scm_is_true( scm_procedure_p(_p))
# define AG_SCM_LIST_P(_l) scm_is_true( scm_list_p(_l))
# define AG_SCM_LISTOFNULL() scm_listofnull
# define AG_SCM_LONG2SCM(_i) gh_long2scm(_i)
# define AG_SCM_NFALSEP(_r) scm_is_true(_r)
# define AG_SCM_NULLP(_m) scm_is_null(_m)
# define AG_SCM_NUM_P(_n) scm_is_number(_n)
# define AG_SCM_PAIR_P(_p) scm_is_true( scm_pair_p(_p))
# define AG_SCM_STR02SCM(_s) scm_from_locale_string(_s)
# define AG_SCM_STR2SCM(_st,_sz) scm_from_locale_stringn(_st,_sz)
# define AG_SCM_STRING_P(_s) scm_is_string(_s)
# define AG_SCM_STRLEN(_s) SCM_STRING_LENGTH(_s)
# define AG_SCM_SYM_P(_s) SCM_SYMBOLP(_s)
# define AG_SCM_TO_INT(_i) gh_scm2int(_i)
# define AG_SCM_TO_LONG(_v) gh_scm2long(_v)
# define AG_SCM_TO_NEWSTR(_s) scm_to_locale_string(_s)
# define AG_SCM_TO_ULONG(_v) gh_scm2ulong(_v)
# define AG_SCM_VEC_P(_v) SCM_VECTORP(_v)
#elif GUILE_VERSION < 109000
# define AG_SCM_APPLY2(_op, _f, _tst) \
scm_apply(_op, _f, scm_cons(_tst, AG_SCM_LISTOFNULL()))
# define AG_SCM_BOOL_P(_b) scm_is_bool(_b)
# define AG_SCM_BOOT_GUILE(_ac, _av, _im) \
scm_boot_guile((_ac), (_av), (_im), NULL)
# define AG_SCM_CHAR(_c) SCM_CHAR(_c)
# define AG_SCM_CHARS(_s) scm_i_string_chars(_s)
# define AG_SCM_CHAR_P(_c) SCM_CHARP(_c)
# define AG_SCM_DISPLAY(_s) \
scm_display(_s, scm_current_output_port())
# define AG_SCM_FALSEP(_r) scm_is_false(_r)
# define AG_SCM_FROM_LONG(_l) scm_from_long(_l)
# define AG_SCM_INT2SCM(_i) scm_from_int(_i)
# define AG_SCM_IS_PROC(_p) scm_is_true( scm_procedure_p(_p))
# define AG_SCM_LIST_P(_l) scm_is_true( scm_list_p(_l))
# define AG_SCM_LISTOFNULL() scm_listofnull
# define AG_SCM_LONG2SCM(_i) scm_from_long(_i)
# define AG_SCM_NFALSEP(_r) scm_is_true(_r)
# define AG_SCM_NULLP(_m) scm_is_null(_m)
# define AG_SCM_NUM_P(_n) scm_is_number(_n)
# define AG_SCM_PAIR_P(_p) scm_is_true( scm_pair_p(_p))
# define AG_SCM_STR02SCM(_s) scm_from_locale_string(_s)
# define AG_SCM_STR2SCM(_st,_sz) scm_from_locale_stringn(_st,_sz)
# define AG_SCM_STRING_P(_s) scm_is_string(_s)
# define AG_SCM_STRLEN(_s) scm_c_string_length(_s)
# define AG_SCM_SYM_P(_s) scm_is_symbol(_s)
# define AG_SCM_TO_INT(_i) scm_to_int(_i)
# define AG_SCM_TO_LONG(_v) scm_to_long(_v)
# define AG_SCM_TO_NEWSTR(_s) scm_to_locale_string(_s)
# define AG_SCM_TO_ULONG(_v) scm_to_ulong(_v)
# define AG_SCM_VEC_P(_v) scm_is_vector(_v)
#elif GUILE_VERSION < 201000
# define AG_SCM_APPLY2(_op, _f, _tst) \
scm_apply(_op, _f, scm_cons(_tst, AG_SCM_LISTOFNULL()))
# define AG_SCM_BOOL_P(_b) scm_is_bool(_b)
# define AG_SCM_BOOT_GUILE(_ac, _av, _im) \
scm_boot_guile((_ac), (_av), (_im), NULL)
# define AG_SCM_CHAR(_c) SCM_CHAR(_c)
# define AG_SCM_CHARS(_s) scm_i_string_chars(_s)
# define AG_SCM_CHAR_P(_c) SCM_CHARP(_c)
# define AG_SCM_DISPLAY(_s) \
scm_display(_s, scm_current_output_port())
# define AG_SCM_FALSEP(_r) scm_is_false(_r)
# define AG_SCM_FROM_LONG(_l) scm_from_long(_l)
# define AG_SCM_INT2SCM(_i) scm_from_int(_i)
# define AG_SCM_IS_PROC(_p) scm_is_true( scm_procedure_p(_p))
# define AG_SCM_LIST_P(_l) scm_is_true( scm_list_p(_l))
# define AG_SCM_LISTOFNULL() scm_list_1(SCM_EOL)
# define AG_SCM_LONG2SCM(_i) scm_from_long(_i)
# define AG_SCM_NFALSEP(_r) scm_is_true(_r)
# define AG_SCM_NULLP(_m) scm_is_null(_m)
# define AG_SCM_NUM_P(_n) scm_is_number(_n)
# define AG_SCM_PAIR_P(_p) scm_is_true( scm_pair_p(_p))
# define AG_SCM_STR02SCM(_s) scm_from_locale_string(_s)
# define AG_SCM_STR2SCM(_st,_sz) scm_from_locale_stringn(_st,_sz)
# define AG_SCM_STRING_P(_s) scm_is_string(_s)
# define AG_SCM_STRLEN(_s) scm_c_string_length(_s)
# define AG_SCM_SYM_P(_s) scm_is_symbol(_s)
# define AG_SCM_TO_INT(_i) scm_to_int(_i)
# define AG_SCM_TO_LONG(_v) scm_to_long(_v)
# define AG_SCM_TO_NEWSTR(_s) scm_to_locale_string(_s)
# define AG_SCM_TO_ULONG(_v) scm_to_ulong(_v)
# define AG_SCM_VEC_P(_v) scm_is_vector(_v)
# define scm_sizet size_t
#else
#error unknown GUILE_VERSION
#endif
#if GUILE_VERSION < 107000 /* pre-Guile 1.7.x */
static inline char * ag_scm2zchars(SCM s, char const * type)
{
if (! AG_SCM_STRING_P(s))
AG_ABEND(aprf(zNotStr, type));
if (SCM_SUBSTRP(s))
s = scm_makfromstr(SCM_CHARS(s), SCM_LENGTH(s), 0);
return SCM_CHARS(s);
}
#else /* Guile 1.7 and following */
extern char * ag_scm2zchars(SCM s, char const * type);
#endif
static inline SCM ag_eval(char const * pzStr)
{
SCM res;
char const * pzSaveScheme = pzLastScheme; /* Watch for nested calls */
pzLastScheme = pzStr;
res = ag_scm_c_eval_string_from_file_line(
pzStr, pCurTemplate->pzTplFile, pCurMacro->lineNo);
pzLastScheme = pzSaveScheme;
return res;
}
prev parent reply other threads:[~2011-03-10 9:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.4.1298297717.17321.info-gnu@gnu.org>
[not found] ` <87vd0cqjvx.fsf@gnu.org>
[not found] ` <4D643043.6080406@gnu.org>
[not found] ` <4D658101.7030307@gnu.org>
[not found] ` <87sjvdl6ce.fsf@gnu.org>
2011-02-24 22:58 ` reprise: scm_c_eval_string_from_file_line Bruce Korb
2011-02-25 11:13 ` Andy Wingo
2011-03-08 22:28 ` Andy Wingo
2011-03-08 22:45 ` Bruce Korb
2011-03-08 22:52 ` Andy Wingo
2011-03-09 6:30 ` Mark H Weaver
2011-03-09 10:07 ` Ludovic Courtès
2011-03-09 20:15 ` Andy Wingo
2011-03-10 9:35 ` Bruce Korb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D789B7C.4050807@gnu.org \
--to=bkorb@gnu.org \
--cc=Ludovic@gnu.org \
--cc=guile-devel@gnu.org \
--cc=ludo@gnu.org \
--cc=wingo@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).