From: lloda <lloda@sarc.name>
To: "Aleix Conchillo Flaqué" <aconchillo@gmail.com>
Cc: guile-devel <guile-devel@gnu.org>
Subject: Re: [PATCH] foreign-library: fix darwin detection
Date: Thu, 2 Sep 2021 09:22:37 +0200 [thread overview]
Message-ID: <4ABFEBBF-1935-42A1-AFCA-ED6CA156DD3E@sarc.name> (raw)
In-Reply-To: <CA+XASoWFVgj3PLT-5BkNOo+V7RH-HPz2QPAg_EY-BJOd9rtA0A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2300 bytes --]
Patch is applied in 1f100a4f20c3a6e57922fb26fce212997e2a03cb, thanks.
However I cannot build Guile on macos at the moment bc of an error in lib/basename-lgpl.h, this seems caused by the last gnulib update :-\
> On 2 Sep 2021, at 07:38, Aleix Conchillo Flaqué <aconchillo@gmail.com> wrote:
>
> Without this change dynamic libraries in macOS are not loaded
> properly. This has happened since 3.0.6.
>
> scheme@(guile-user)> %host-type
> $1 = "x86_64-apple-darwin20.5.0"
>
> --------------------------------
>
> scheme@(guile-user)> (use-modules (git))
> While compiling expression:
> In procedure git_libgit2_init: Function not implemented
>
> --------------------------------
>
> scheme@(guile-user)> (use-modules (system foreign))
> scheme@(guile-user)> (dynamic-link "/usr/local/lib/libgit2")
> ice-9/boot-9.scm:1685:16: In procedure raise-exception:
> In procedure load-foreign-library: file: "/usr/local/lib/libgit2",
> message: "file not found"
>
> Entering a new prompt. Type `,bt' for a backtrace or `,q' to continue.
> scheme@(guile-user) [1]>
>
> --------------------------------
>
> After this fix:
>
> scheme@(guile-user)> (use-modules (system foreign))
> scheme@(guile-user)> (dynamic-link "/usr/local/lib/libgit2")
> $2 = #<<foreign-library> filename: "/usr/local/lib/libgit2" handle:
> #<pointer 0x7ffed3104ac0>>
>
> On Wed, Sep 1, 2021 at 10:28 PM Aleix Conchillo Flaqué
> <aconchillo@gmail.com> wrote:
>>
>> * module/system/foreign-library.scm (system-library-extensions): fix
>> darwin host detection. darwin host types have "-darwin" but not
>> "-darwin-".
>> ---
>> module/system/foreign-library.scm | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/module/system/foreign-library.scm b/module/system/foreign-library.scm
>> index d53e293ef..dc426385f 100644
>> --- a/module/system/foreign-library.scm
>> +++ b/module/system/foreign-library.scm
>> @@ -48,7 +48,7 @@
>>
>> (define system-library-extensions
>> (cond
>> - ((string-contains %host-type "-darwin-")
>> + ((string-contains %host-type "-darwin")
>> '(".bundle" ".so" ".dylib"))
>> ((or (string-contains %host-type "cygwin")
>> (string-contains %host-type "mingw")
>> --
>> 2.33.0
>>
>
[-- Attachment #2: Type: text/html, Size: 4148 bytes --]
prev parent reply other threads:[~2021-09-02 7:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 5:27 [PATCH] foreign-library: fix darwin detection Aleix Conchillo Flaqué
2021-09-02 5:38 ` Aleix Conchillo Flaqué
2021-09-02 6:53 ` Aleix Conchillo Flaqué
2021-09-02 7:22 ` lloda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ABFEBBF-1935-42A1-AFCA-ED6CA156DD3E@sarc.name \
--to=lloda@sarc.name \
--cc=aconchillo@gmail.com \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).