From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Neil Jerram" Newsgroups: gmane.lisp.guile.devel Subject: Re: git head fails to build Date: Wed, 14 Jan 2009 21:45:22 +0000 Message-ID: <49dd78620901141345l1b955943m2a52c44186ddd3e@mail.gmail.com> References: <49dd78620901141205v206f1620j454098d902e42b58@mail.gmail.com> <49dd78620901141254r2cad1945wdc2bc5e03f23dec3@mail.gmail.com> <878wpdr2xe.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1231969695 4000 80.91.229.12 (14 Jan 2009 21:48:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 14 Jan 2009 21:48:15 +0000 (UTC) Cc: guile-devel@gnu.org To: "=?ISO-8859-1?Q?Ludovic_Court=E8s?=" Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Jan 14 22:49:27 2009 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LNDc7-0001sT-5n for guile-devel@m.gmane.org; Wed, 14 Jan 2009 22:49:27 +0100 Original-Received: from localhost ([127.0.0.1]:50831 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LNDaq-0004ov-LP for guile-devel@m.gmane.org; Wed, 14 Jan 2009 16:48:08 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LNDYF-00037S-G8 for guile-devel@gnu.org; Wed, 14 Jan 2009 16:45:27 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LNDYD-00035f-HL for guile-devel@gnu.org; Wed, 14 Jan 2009 16:45:26 -0500 Original-Received: from [199.232.76.173] (port=47027 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LNDYD-00035Q-AL for guile-devel@gnu.org; Wed, 14 Jan 2009 16:45:25 -0500 Original-Received: from mail-bw0-f15.google.com ([209.85.218.15]:52289) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LNDYC-0001ZL-0U; Wed, 14 Jan 2009 16:45:24 -0500 Original-Received: by bwz8 with SMTP id 8so580307bwz.18 for ; Wed, 14 Jan 2009 13:45:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=7bkc5bb5ewKycVG0RCC11GaA/RG64GmwaEPfvDDrahA=; b=IhcPhYa6rENbstJO2QtKMcAdJMHwizTbmxUx8zTCXnkul0enyDaOTy3uvgm8xmnhTk u9OHrd3W9JcXVpY/7r7VcmG0JBIG2NiuZeKXQiisopk18D8JTGzyttTz0JWOJU7lN+3k yDf7PJERMqYj1+WKIvECZWgaK3ozriOS9M7QM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=wZRAQSc6Wwe0/QFb2AkvykpNrL+i/kFWL8D2MAYFkalbEiLJBCQd1rgruwCoUymBk2 LJT4ClDnfXfcZqBS0pt5D06wAmG9ot4wV0JfNcJChPZYHwSRziv9jBf67CC6lBNIPPtG hLp2ffA+NNFmKU7lUrlAzZVc23qBEcRRRLvco= Original-Received: by 10.180.218.15 with SMTP id q15mr160171bkg.194.1231969522472; Wed, 14 Jan 2009 13:45:22 -0800 (PST) Original-Received: by 10.181.208.17 with HTTP; Wed, 14 Jan 2009 13:45:22 -0800 (PST) In-Reply-To: <878wpdr2xe.fsf@gnu.org> Content-Disposition: inline X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:8015 Archived-At: 2009/1/14 Ludovic Court=E8s : > Hello Neil, > > I've been working on this in parallel, so I thought it'd be better to > get in sync. ;-) Thank you! > I had (hopefully) fixed the problem by reverting your commits in reverse > order and starting anew (attached patch). The problem is that commit > 4a462e35440fdc3f10b0f88b3fb737fa76ed146d touches way too many files: it > adds generated `.h' files (which is boring since they then have to be > removed before one can `pull' or `checkout'), it modifies > `m4/.gitignore' (which we don't want precisely because we commit > Gnulib's M4 files), it adds `lib/.gitignore', it modifies `INSTALL', > etc. Right. Since my last message, I realized that Gnulib by default is assuming that one won't commit its files, and hence it adds them to .gitignore. > I find it tricky to update Gnulib files since we store them in the repo. > It's easy when one doesn't store them in the repository because it > updates `.gitignore', etc., but it gets harder when one stores them in > the repo. We should use "gnulib-update --no-vc-files" actually (info > "(gnulib) VCS Issues"), but we still have to make sure we don't commit > generated files. Cool, I'll try to remember that in future. Your patch looks good - except that we should also delete libguile/alloca.c. I can do that in a separate commit if you prefer. I was on the point of reaching the same endpoint, by doing $ rm * $ git checkout master -- . $ ../../gnulib/gnulib-tool -- import $ git status And then the git status output tells you which Gnulib files should be commi= tted. But given that your patch is ready to go, please commit it. Neil