From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Neil Jerram" Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Use Gnulib's `strftime' Date: Wed, 17 Sep 2008 22:17:36 +0200 Message-ID: <49dd78620809171317x6eb44b14p8cdf964d05704ba5@mail.gmail.com> References: <877i9ugvtr.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1221682686 4207 80.91.229.12 (17 Sep 2008 20:18:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 17 Sep 2008 20:18:06 +0000 (UTC) Cc: guile-devel@gnu.org To: "=?ISO-8859-1?Q?Ludovic_Court=E8s?=" Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Sep 17 22:19:02 2008 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kg3UE-0000Hd-1Y for guile-devel@m.gmane.org; Wed, 17 Sep 2008 22:18:54 +0200 Original-Received: from localhost ([127.0.0.1]:45195 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kg3TC-0003dY-OE for guile-devel@m.gmane.org; Wed, 17 Sep 2008 16:17:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kg3T5-0003az-Ee for guile-devel@gnu.org; Wed, 17 Sep 2008 16:17:43 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kg3T3-0003Y4-Ny for guile-devel@gnu.org; Wed, 17 Sep 2008 16:17:42 -0400 Original-Received: from [199.232.76.173] (port=38582 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kg3T3-0003UW-Dy for guile-devel@gnu.org; Wed, 17 Sep 2008 16:17:41 -0400 Original-Received: from rv-out-0708.google.com ([209.85.198.250]:4857) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kg3T0-0005yh-4v for guile-devel@gnu.org; Wed, 17 Sep 2008 16:17:38 -0400 Original-Received: by rv-out-0708.google.com with SMTP id k29so3742250rvb.6 for ; Wed, 17 Sep 2008 13:17:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=we0kxp/U/cZlgsbJbHxKWSajZCQDIMSdIwqdTPW1U6w=; b=EEh0T4DnAv4WtmI5hggXspxPkq1InSo8oz/YrA/uvhxHNJsUImd5JZHM+TmkaVoA7c fzmFtdRZwOgPCPlGSKRGwBd8NywvDo6drwS/OAVrGp/9OZw1UUVjKNaAFAx2Fh1oshPo YawyPtWLmDqPizpzesbb0JqcYNYdGdCyXht6Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=lhKdHRGD5tLK/Zz5YDpdF8we/iIul4gcQjpkmORSCkQf+R8oXecYm9EQ9AqSXrlfXz tkMaT1uz47o70b+WHS5QlvfUc2cdDs3/t+lmFRFR1ILbLU09nkD07ImJiD3xUImFo1Co znwxQRQtFMBXm+4jH9ye33O0TZTmdN5WmThlQ= Original-Received: by 10.141.18.15 with SMTP id v15mr6800440rvi.296.1221682656747; Wed, 17 Sep 2008 13:17:36 -0700 (PDT) Original-Received: by 10.140.142.15 with HTTP; Wed, 17 Sep 2008 13:17:36 -0700 (PDT) In-Reply-To: <877i9ugvtr.fsf@gnu.org> Content-Disposition: inline X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:7710 Archived-At: Hi Ludo... 2008/9/2 Ludovic Court=E8s : > Hello! > > I'm planning to use Gnulib's `strftime' module on `master' to fix > portability problems related to `strftime', aka. #24130 > (https://savannah.gnu.org/bugs/?24130). The good thing is that > `strftime' will now work the same regardless of the underlying libc. Excellent! > The source modification is attached. I'm just a bit confused about %Z, because it seems to me that the documentation contradicts the test. Here's the doc change: > +Note that @samp{%Z} always ignores the @code{tm:zone} in @var{tm}; > +instead it prints just the current zone (@code{tzset} above). Here's the test: > + (pass-if "strftime %Z doesn't return garbage" > + (let ((t (localtime (current-time)))) > + (set-tm:zone t "ZOW") > + (set-tm:isdst t 0) > + (string=3D? (strftime "%Z" t) > + "ZOW"))) The doc seems to be saying that (strftime "%Z" tm) will ignore TM's zone, but the test makes it look like (strftime "%Z" tm) uses TM's zone. Am I misunderstanding? Regards, Neil