Re: [PATCH] Use Gnulib's `strftime'

["Neil Jerram" <neiljerram@googlemail.com>]

Hi Ludo...

2008/9/2 Ludovic Courtès <ludo@gnu.org>:
> Hello!
>
> I'm planning to use Gnulib's `strftime' module on `master' to fix
> portability problems related to `strftime', aka. #24130
> (https://savannah.gnu.org/bugs/?24130).  The good thing is that
> `strftime' will now work the same regardless of the underlying libc.

Excellent!

> The source modification is attached.

I'm just a bit confused about %Z, because it seems to me that the
documentation contradicts the test.

Here's the doc change:

> +Note that @samp{%Z} always ignores the @code{tm:zone} in @var{tm};
> +instead it prints just the current zone (@code{tzset} above).

Here's the test:

> +  (pass-if "strftime %Z doesn't return garbage"
> +    (let ((t (localtime (current-time))))
> +      (set-tm:zone t "ZOW")
> +      (set-tm:isdst t 0)
> +      (string=? (strftime "%Z" t)
> +                "ZOW")))

The doc seems to be saying that (strftime "%Z" tm) will ignore TM's
zone, but the test makes it look like (strftime "%Z" tm) uses TM's
zone.  Am I misunderstanding?

Regards,
      Neil