From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Han-Wen Nienhuys Newsgroups: gmane.lisp.guile.devel Subject: Re: port-for-each vs lazy sweep Date: Sun, 26 Aug 2007 14:16:18 -0300 Message-ID: <46D1B562.5030104@xs4all.nl> References: <878x88pbcc.fsf@zip.com.au> <46D0AB14.3030508@xs4all.nl> <8764328bxq.fsf@chbouib.org> Reply-To: hanwen@xs4all.nl NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1188149047 23349 80.91.229.12 (26 Aug 2007 17:24:07 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 26 Aug 2007 17:24:07 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sun Aug 26 19:24:04 2007 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IPLqG-0003yU-8r for guile-devel@m.gmane.org; Sun, 26 Aug 2007 19:24:04 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IPLqF-0007VU-LD for guile-devel@m.gmane.org; Sun, 26 Aug 2007 13:24:03 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IPLqA-0007UP-Si for guile-devel@gnu.org; Sun, 26 Aug 2007 13:23:58 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IPLqA-0007UC-Gq for guile-devel@gnu.org; Sun, 26 Aug 2007 13:23:58 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IPLqA-0007U8-9C for guile-devel@gnu.org; Sun, 26 Aug 2007 13:23:58 -0400 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IPLq9-0001c9-OF for guile-devel@gnu.org; Sun, 26 Aug 2007 13:23:58 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1IPLpz-0003Af-Kx for guile-devel@gnu.org; Sun, 26 Aug 2007 19:23:47 +0200 Original-Received: from c911de45.bhz.virtua.com.br ([201.17.222.69]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 26 Aug 2007 19:23:47 +0200 Original-Received: from hanwen by c911de45.bhz.virtua.com.br with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 26 Aug 2007 19:23:47 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 56 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: c911de45.bhz.virtua.com.br User-Agent: Thunderbird 2.0.0.5 (X11/20070719) In-Reply-To: <8764328bxq.fsf@chbouib.org> X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:6756 Archived-At: Ludovic Courtès escreveu: >> @@ -472,6 +480,7 @@ scm_i_init_guile (SCM_STACKITEM *base) >> scm_init_backtrace (); /* Requires fluids */ >> scm_init_fports (); >> scm_init_strports (); >> + scm_init_ports (); >> scm_init_gdbint (); /* Requires strports */ >> scm_init_hash (); >> scm_init_hashtab (); >> @@ -490,7 +499,6 @@ scm_i_init_guile (SCM_STACKITEM *base) >> scm_init_numbers (); >> scm_init_options (); >> scm_init_pairs (); >> - scm_init_ports (); > > Why does it need to be moved? because gdb instantiates a port; I forgot why it used to work though. >> - SCM_SETPTAB_ENTRY (port, pt); >> + SCM_SETPTAB_ENTRY(port, pt); > > Please follow GNU style. I have the impression that GUILE isn't really consistent [lilydev@haring libguile]$ grep '[A-Z](' *c|grep -v define|wc 394 2037 24632 [lilydev@haring libguile]$ grep '[a-z](' *c|grep -v define|wc 490 3038 28008 time for a grand search & replace patch? >> -#ifdef GUILE_DEBUG >> /* Functions for debugging. */ > > Why remove the `#ifdef'? oops. > >> --- a/m4/gnulib-cache.m4 >> +++ b/m4/gnulib-cache.m4 >> @@ -23,6 +23,7 @@ gl_MODULES([alloca strcase]) >> gl_AVOID([]) >> gl_SOURCE_BASE([lib]) >> gl_M4_BASE([m4]) >> +gl_PO_BASE([]) > > This is unrelated. yes, I know. Too lazy to strip this from the output. But won't apply to CVS. -- Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel