unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Han-Wen Nienhuys <hanwen@xs4all.nl>
To: guile-devel@gnu.org
Cc: Neil Jerram <neil@ossau.uklinux.net>
Subject: Re: freeing srcprops ?
Date: Tue, 30 Jan 2007 13:52:37 +0100	[thread overview]
Message-ID: <45BF3F95.8040002@xs4all.nl> (raw)
In-Reply-To: <66e540fe0701300421j7188a6c1s7add06f21356abf9@mail.gmail.com>

Mikael Djurfeldt escreveu:
>> 3. Due to sharing of the filename cons, memory usage is slightly more
>> than 4 SCMs per srcprop, down from 6 SCMs (2 for the smob cell, 4 for the
>> struct)
> 
> Hmm...  Your filename optimization doesn't really work, does it?  As
> soon as someone sets a breakpoint, he gets it all over the place, or
> did I miss something?

from what I could follow from the code, srcprops were mainly constructed in 
the reader. However, I would gladly remove that bit too, and simply go for 
cons-cell with struct pointer, but without the special memory pool.

Neil, is that acceptable?

> If we considered implementing source properties *now*, I would
> probably agree.  But the code is already there and I wonder if there
> really is any gain of replacing it.  

It's a question of philosophy. IMO, at any time, the source code of a project
should reflect how you would implement it "now"

-- 
 Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen



_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel


      reply	other threads:[~2007-01-30 12:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-17  0:22 freeing srcprops ? Han-Wen Nienhuys
2007-01-18 14:04 ` Han-Wen Nienhuys
2007-01-18 23:28   ` Kevin Ryde
2007-01-19 10:37     ` Han-Wen Nienhuys
2007-01-19 11:52     ` Han-Wen Nienhuys
2007-01-26 22:15       ` Kevin Ryde
2007-01-26 23:33         ` Han-Wen Nienhuys
2007-01-18 23:20 ` Kevin Ryde
2007-01-28  9:08   ` Neil Jerram
2007-01-29 11:39     ` Han-Wen Nienhuys
2007-01-29 21:35       ` Neil Jerram
2007-01-29 23:31         ` Han-Wen Nienhuys
2007-01-30 12:40           ` Ludovic Courtès
2007-01-30 19:14             ` Han-Wen Nienhuys
2007-01-30 12:21       ` Mikael Djurfeldt
2007-01-30 12:52         ` Han-Wen Nienhuys [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45BF3F95.8040002@xs4all.nl \
    --to=hanwen@xs4all.nl \
    --cc=guile-devel@gnu.org \
    --cc=neil@ossau.uklinux.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).