From: Han-Wen Nienhuys <hanwen@xs4all.nl>
Subject: Re: regexp-exec critcial section errors
Date: Thu, 18 Jan 2007 14:58:04 +0100 [thread overview]
Message-ID: <45AF7CEC.5000005@xs4all.nl> (raw)
In-Reply-To: <87r6tyin03.fsf@zip.com.au>
Kevin Ryde escreveu:
> In regexp-exec in 1.8, a nul in the input string, or a bad flags arg,
> results in a throw from a critical section, which calls abort(). Eg.
>
> (regexp-exec (make-regexp "x") "\0")
> => abort
>
> (regexp-exec (make-regexp "x") "hello" 0 'badflags)
> => abort
>
> What's the reason for the critical section? Do we think regexec() is
> not reentrant? It looks like a conversion from SCM_DEFER_INTS in past
> versions, if that suggests anything about it.
>
> I struck this when running a regexp search on some file data that
> slightly unexpectedly had nuls in it. I think I was using 1.6 last
> time I did the same thing. I guess that version silently ignores past
> the nul. Maybe that should get a check, though there's probably a
> zillion libc calls that would really ought to have the same.
Ehm,
I get
**
Running reader.test
Running receive.test
Running regexp.test
ERROR: Unbound variable: exception:string-contains-nul
FAIL: check-guile
==================================
**
it might be a good idea to have an autobuild daemon that compiles and
checks the test-suite.
--
Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen
_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel
next prev parent reply other threads:[~2007-01-18 13:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-13 22:24 regexp-exec critcial section errors Kevin Ryde
2007-01-18 13:58 ` Han-Wen Nienhuys [this message]
2007-01-18 23:07 ` Kevin Ryde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45AF7CEC.5000005@xs4all.nl \
--to=hanwen@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).