From: Han-Wen Nienhuys <hanwen@xs4all.nl>
Subject: Re: [PATCH] Marking weak alist vectors
Date: Wed, 09 Nov 2005 11:28:22 +0100 [thread overview]
Message-ID: <4371CF46.4010708@xs4all.nl> (raw)
In-Reply-To: <87y83z3vh5.fsf@laas.fr>
Ludovic Courtès wrote:
> The patch fixes `scm_i_mark_weak_vector_non_weaks ()'. This way, a
> value attached to a weak key will only become unmarked during the mark
> phase _after_ the mark phase during which its weak key became unmarked.
> You might want to re-read this sentence carefully. ;-)
Does your patch solve the problem that cyclical structures (values that
point back to keys) should also be GC-ed?
> /* Attach TO_BE_ATTACHED to OBJ. */
> static SCM
> attach_object (SCM obj, SCM to_be_attached)
> {
> my_object_t *c_obj, *c_to_be_attached;
>
> assert (SCM_SMOB_PREDICATE (my_object_type, obj));
> assert (SCM_SMOB_PREDICATE (my_object_type, to_be_attached));
>
> /* TO_BE_ATTACHED is attached as a property of OBJ. As such, OBJ will get
> GC'd _before_ TO_BE_ATTACHED. */
> scm_primitive_property_set_x (some_property, obj, to_be_attached);
Why are you storing SCM references as properties? It's more efficient
both in time and space to use a SCM member in my_object_t.
--
Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen
_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel
next prev parent reply other threads:[~2005-11-09 10:28 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-08 17:22 [PATCH] Marking weak alist vectors Ludovic Courtès
2005-11-08 23:51 ` Marius Vollmer
2005-11-09 9:03 ` Ludovic Courtès
2005-12-06 23:55 ` Marius Vollmer
2005-12-07 10:33 ` Ludovic Courtès
2005-12-13 23:45 ` Marius Vollmer
2005-12-14 9:30 ` Ludovic Courtès
2005-11-09 10:28 ` Han-Wen Nienhuys [this message]
2005-11-09 16:28 ` Ludovic Courtès
2005-11-09 18:36 ` Han-Wen Nienhuys
2005-11-09 21:11 ` Kevin Ryde
2005-11-09 22:45 ` Marius Vollmer
2005-11-10 12:11 ` Han-Wen Nienhuys
2005-11-10 9:47 ` [PATCH] Reference leak in `iprin1 ()' Ludovic Courtès
2005-11-12 9:23 ` Neil Jerram
2005-11-14 9:58 ` Ludovic Courtès
2005-11-16 21:18 ` Neil Jerram
2005-11-17 9:54 ` Ludovic Courtès
2005-11-17 18:52 ` Neil Jerram
2005-11-23 10:19 ` [PATCH] Marking weak alist vectors, #2 Ludovic Courtès
2005-11-24 0:59 ` Han-Wen Nienhuys
2005-11-24 9:01 ` Ludovic Courtès
2005-11-26 0:49 ` Kevin Ryde
2006-01-09 14:51 ` [PATCH] Marking weak alist vectors, epilogue Ludovic Courtès
2006-01-09 19:29 ` Neil Jerram
2006-01-10 8:21 ` Ludovic Courtès
2006-01-10 9:33 ` Neil Jerram
2006-01-10 15:43 ` Ludovic Courtès
2005-11-17 13:21 ` [PATCH] Fixing `gc-live-object-stats' Ludovic Courtès
2005-11-17 14:12 ` Han-Wen Nienhuys
2005-11-30 8:54 ` Ludovic Courtès
2005-11-30 23:45 ` Han-Wen Nienhuys
2005-12-03 19:31 ` Neil Jerram
2005-12-05 8:50 ` Ludovic Courtès
2005-12-06 19:14 ` Neil Jerram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4371CF46.4010708@xs4all.nl \
--to=hanwen@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).