From: Maxime Devos <maximedevos@telenet.be>
To: rob piko <kostyarjcnz@gmail.com>, tomas@tuxteam.de
Cc: guile-devel@gnu.org
Subject: Re: [PATCH] Bindings to *at functions & allowing more functions to operate on ports
Date: Wed, 05 May 2021 12:11:25 +0200 [thread overview]
Message-ID: <43055cc9da778fc2388a817489bb6b5b95cde6ae.camel@telenet.be> (raw)
In-Reply-To: <CAL-cBfZuS3KgCd_wOAe_w0M=OmBFrgvQkeJpe8jdfVSeNwr9fg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]
rob piko schreef op di 04-05-2021 om 18:58 [-0400]:
> Hello Maxime,
>
> > * Use O_NOFOLLOW to *not* follow the symbolic link.
> > Patch for adding O_NOFOLLOW to guile:
>
> According to the man pages for the O_NOFOLLOW:
>
> > If the trailing component (i.e., basename) of pathname is
> > a symbolic link, then the open fails, with the error
> > ELOOP. Symbolic links in earlier components of the
> > pathname will still be followed.
>
> Sounds like O_NOFOLLOW would not fix the issue if the symlink is found in other parts of the pathname outside of the basename?
Indeed! To avoid *all* symlinks, and not only a symlink in the trailing component,
you would need to call 'open' with O_NOFOLLOW in a loop.
Something like:
(let* ((dir (open "/symlinks/acceptable-here" O_RDONLY))
;; Symlinks are not followed here.
(dir* (openat dir "dir" (logior O_RDONLY O_NOFOLLOW)))
(file (openat dir* "file" (logior O_RDONLY O_NOFOLLOW))))
(close dir)
(close dir*)
file)
It has been a while since I wrote the patch though, maybe the argument
order is a little different.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2021-05-05 10:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 21:59 [PATCH] Bindings to *at functions & allowing more functions to operate on ports Maxime Devos
2021-03-27 21:19 ` Maxime Devos
2021-03-28 11:17 ` tomas
2021-05-04 22:58 ` rob piko
2021-05-05 10:11 ` Maxime Devos [this message]
2021-11-16 11:06 ` [PATCH v2 00/14] Bindings to *at functions Maxime Devos
2021-11-16 11:06 ` [PATCH v2 01/14] Allow file ports in ‘chdir’ when supported Maxime Devos
2021-11-16 12:18 ` Maxime Devos
2021-11-16 17:10 ` Maxime Devos
2021-11-16 11:06 ` [PATCH v2 02/14] Allow file ports in ‘readlink’ Maxime Devos
2021-11-16 11:06 ` [PATCH v2 03/14] Allow file ports in ‘utime’ Maxime Devos
2021-11-16 11:06 ` [PATCH v2 04/14] Define ‘symlinkat’ wrapper when supported Maxime Devos
2021-11-16 11:06 ` [PATCH v2 05/14] Define bindings to ‘mkdirat’ when the C function exists Maxime Devos
2021-11-16 11:06 ` [PATCH v2 06/14] Correct documentation of ‘mkdir’ w.r.t. the umask Maxime Devos
2021-11-16 11:06 ` [PATCH v2 07/14] Define AT_REMOVEDIR and others when available Maxime Devos
2021-11-16 11:06 ` [PATCH v2 08/14] Define a Scheme binding to ‘renameat’ when it exists Maxime Devos
2021-11-16 11:06 ` [PATCH v2 09/14] Define a Scheme binding to ‘fchmodat’ " Maxime Devos
2021-11-16 11:06 ` [PATCH v2 10/14] Define a Scheme binding to ‘unlinkat’ " Maxime Devos
2021-11-16 11:06 ` [PATCH v2 11/14] Define a Scheme binding to ‘fchownat’ " Maxime Devos
2021-11-16 11:06 ` [PATCH v2 12/14] Define a Scheme binding to ‘fstatat’ when available Maxime Devos
2021-11-16 11:06 ` [PATCH v2 13/14] Define Scheme bindings to ‘openat’ " Maxime Devos
2021-11-16 11:06 ` [PATCH v2 14/14] Update NEWS Maxime Devos
2021-11-16 12:16 ` Maxime Devos
2022-06-16 8:42 ` [PATCH v2 00/14] Bindings to *at functions Ludovic Courtès
2022-10-21 15:59 ` Ludovic Courtès
2022-10-21 16:03 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43055cc9da778fc2388a817489bb6b5b95cde6ae.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=guile-devel@gnu.org \
--cc=kostyarjcnz@gmail.com \
--cc=tomas@tuxteam.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).